From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kai Huang <kai.huang@linux.intel.com>
Subject: Re: [v2 10/11] log-dirty: refine common code to support
 PML
Date: Fri, 17 Apr 2015 10:47:01 +0800
Message-ID: <55307425.60009@linux.intel.com>
References: <1429081433-9600-1-git-send-email-kai.huang@linux.intel.com>	<1429081433-9600-11-git-send-email-kai.huang@linux.intel.com>	<552FF6A50200007800072E58@mail.emea.novell.com>
	<AADFC41AFE54684AB9EE6CBC0274A5D126211C64@SHSMSX101.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <AADFC41AFE54684AB9EE6CBC0274A5D126211C64@SHSMSX101.ccr.corp.intel.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: "Tian, Kevin" <kevin.tian@intel.com>, Jan Beulich <JBeulich@suse.com>
Cc: "andrew.cooper3@citrix.com" <andrew.cooper3@citrix.com>, "tim@xen.org" <tim@xen.org>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org



On 04/17/2015 07:07 AM, Tian, Kevin wrote:
>> From: Jan Beulich [mailto:JBeulich@suse.com]
>> Sent: Thursday, April 16, 2015 11:52 PM
>>
>>>>> On 15.04.15 at 09:03, <kai.huang@linux.intel.com> wrote:
>>> @@ -190,9 +196,15 @@ static int hap_enable_log_dirty(struct domain *d,
>> bool_t log_global)
>>>       d->arch.paging.mode |= PG_log_dirty;
>>>       paging_unlock(d);
>>>
>>> +    /* enable hardware-assisted log-dirty if it is supported */
>>> +    p2m_enable_hardware_log_dirty(d);
>> I don't see that you would anywhere avoid setting up software
>> log-dirty handling - is that on purpose? If so, is there really a
>> win from adding PML?
>>
>>>       if ( log_global )
>>>       {
>>> -        /* set l1e entries of P2M table to be read-only. */
>>> +        /*
>>> +         * switch to log dirty mode, either by setting l1e entries of P2M
>> table
>>> +         * to be read-only, or via hardware-assisted log-dirty.
>>> +         */
>>>           p2m_change_entry_type_global(d, p2m_ram_rw,
>> p2m_ram_logdirty);
>>
>> Or did I miss you changing the behavior of this anywhere (as the
>> changed comment suggests)?
>>
> just found behavior is changed in [11/11]. :-)
Yes.

Thanks,
-Kai
>
> Thanks
> Kevin
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel