From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [PATCH 02/19] xen: arm: add missing break Date: Fri, 17 Apr 2015 07:06:27 +0100 Message-ID: <5530A2E3.9020409@citrix.com> References: <1427796446.2115.34.camel@citrix.com> <1427796462-24376-2-git-send-email-ian.campbell@citrix.com> <551D5BA2.1060903@citrix.com> <1429200504.25195.171.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1429200504.25195.171.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Julien Grall Cc: xen-devel@lists.xen.org, julien.grall@linaro.org, tim@xen.org, stefano.stabellini@eu.citrix.com List-Id: xen-devel@lists.xenproject.org Hi Ian, On 16/04/2015 17:08, Ian Campbell wrote: > On Thu, 2015-04-02 at 16:09 +0100, Julien Grall wrote: >> Hi Ian, >> >> On 31/03/2015 11:07, Ian Campbell wrote: >>> Signed-off-by: Ian Campbell >>> >>> xen: arm: Fix handling of ICC_{SGI1R,SGI0R,ASGI1R}_EL1 >>> >>> Having injected an undefined instruction we don't want to also advance >>> pc. So return. >>> >>> THe ICC_{SGI0R,ASGI1R}_EL1 case was previously missing a break, so >>> would have fallen through to the default case and injected a second >>> undef, corrupting SPSR_EL1 and ELR_EL1 for the guest. >>> >>> Signed-off-by: Ian Campbell >> Reviewed-by: Julien Grall > > Thanks. I seem to have two commit messages for this one, I think from a > botched patch squash. > > I've dropped the "add missing break" commit message, since I've actually > written about it in the final paragraph. I've kept your R-by regardless, > which I hope is ok. I'm fine with the change. Regards, -- Julien Grall