From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kai Huang <kai.huang@linux.intel.com>
Subject: Re: [v2 11/11] p2m/ept: enable PML in p2m-ept for
	log-dirty
Date: Fri, 17 Apr 2015 15:10:22 +0800
Message-ID: <5530B1DE.2000405@linux.intel.com>
References: <1429081433-9600-1-git-send-email-kai.huang@linux.intel.com>	<1429081433-9600-12-git-send-email-kai.huang@linux.intel.com>	<552FF75D0200007800072E5B@mail.emea.novell.com>	<553072A9.5090909@linux.intel.com>
	<5530C43F02000078000730E3@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <5530C43F02000078000730E3@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: andrew.cooper3@citrix.com, kevin.tian@intel.com, tim@xen.org, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org



On 04/17/2015 02:28 PM, Jan Beulich wrote:
>>>> On 17.04.15 at 04:40, <kai.huang@linux.intel.com> wrote:
>> On 04/16/2015 11:54 PM, Jan Beulich wrote:
>>>>>> On 15.04.15 at 09:03, <kai.huang@linux.intel.com> wrote:
>>>> This patch firstly enables EPT A/D bits if PML is used, as PML depends on
>> EPT
>>>> A/D bits to work. A bit is set for all present leaf p2m types, D bit is set
>> for
>>>> all writable types, except log-dirty type.
>>> I think the tying of "leaf" to the A bit part of the description became
>>> stale, as you're now also doing this for non-leaf ones.
>> You are right. How about just "A bit is set for all present p2m types, ..."?
> Almost - adding "leaf" to the D bit part would still be desirable for
> clarity.
That will be more accurate. Thanks for suggestion. Is below good to you?

"A bit is set for all present p2m types in middle and leaf EPT entries, 
and D bit is set for all writable types in the leaf EPT entry, except 
log-dirty type."

And I will update comments at the beginning of ept_p2m_type_to_flags 
accordingly.

Thanks,
-Kai
>
> Jan
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel