From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46964) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yj0VT-0005g8-Rv for qemu-devel@nongnu.org; Fri, 17 Apr 2015 03:16:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yj0VR-0006q7-JK for qemu-devel@nongnu.org; Fri, 17 Apr 2015 03:16:07 -0400 Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:60314 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yj0VR-0006pt-5m for qemu-devel@nongnu.org; Fri, 17 Apr 2015 03:16:05 -0400 Message-ID: <5530B331.2060006@kamp.de> Date: Fri, 17 Apr 2015 09:16:01 +0200 From: Peter Lieven MIME-Version: 1.0 References: <1429186730-3866-1-git-send-email-pl@kamp.de> <1429186730-3866-8-git-send-email-pl@kamp.de> <552FAC28.80403@redhat.com> <552FB1EC.5070606@kamp.de> <552FB725.7020905@redhat.com> In-Reply-To: <552FB725.7020905@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.4 07/10] block/iscsi: bump libiscsi requirement to 1.10.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: ronniesahlberg@gmail.com, qemu-block@nongnu.org Am 16.04.2015 um 15:20 schrieb Paolo Bonzini: > > On 16/04/2015 14:58, Peter Lieven wrote: >>> On 16/04/2015 14:18, Peter Lieven wrote: >>>> We need this to support SCSI_STATUS_TASK_SET_FULL. >>> Any reason apart from the missing constant? >> No, but I wanted to avoid starting checking for constants that were >> added shortly after this. >> You can't check with #ifdef for a constant in an enum. > But you can #define it if libiscsi version is <1.10. There is no macro to check for that. I took the easy way hardcoding the value. Its an official standard so there is no chance it will change. Peter