From: Daniel Borkmann <daniel@iogearbox.net>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Mathias Nyman <m.nyman@iki.fi>
Cc: netdev@vger.kernel.org, aleksi.aalto@iki.fi
Subject: Re: [PATCH net-next] ip: Add color output option
Date: Fri, 17 Apr 2015 19:26:54 +0200 [thread overview]
Message-ID: <5531425E.1020206@iogearbox.net> (raw)
In-Reply-To: <20150417164402.GA7041@Alexeis-MBP.westell.com>
On 04/17/2015 06:44 PM, Alexei Starovoitov wrote:
> On Fri, Apr 17, 2015 at 04:02:02PM +0300, Mathias Nyman wrote:
>> It is hard to quickly find what you are looking for in the output of the ip
>> command. Color helps.
>>
>> This patch adds a '-c' flag to highlight these with individual colors:
>> - interface name
>> - ip addresse
>> - mac addresse
>> - up/down state
>
> idea looks good, but the patch doesn't apply at all, since it's
> whitespace damaged. Also there is no SOB.
You also might want to move the library bits into lib/ so that
not only ip but also other tools could use it in future. So -c
is neither taken in ip nor in tc or ss, that's good. ;)
next prev parent reply other threads:[~2015-04-17 17:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-17 13:02 [PATCH net-next] ip: Add color output option Mathias Nyman
2015-04-17 16:44 ` Alexei Starovoitov
2015-04-17 17:26 ` Daniel Borkmann [this message]
2015-04-18 10:22 ` Mathias Nyman
2015-04-19 8:22 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5531425E.1020206@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=aleksi.aalto@iki.fi \
--cc=alexei.starovoitov@gmail.com \
--cc=m.nyman@iki.fi \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.