From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel De Graaf Subject: Re: [PATCH v5 p2 04/19] xen/arm: Implement hypercall DOMCTL_{, un}bind_pt_pirq Date: Fri, 17 Apr 2015 19:05:32 -0400 Message-ID: <553191BC.3080401@tycho.nsa.gov> References: <1428592185-18581-1-git-send-email-julien.grall@citrix.com> <1428592185-18581-5-git-send-email-julien.grall@citrix.com> <1429196139.25195.148.camel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YjFKx-0003MX-Ca for xen-devel@lists.xenproject.org; Fri, 17 Apr 2015 23:06:15 +0000 In-Reply-To: <1429196139.25195.148.camel@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Julien Grall Cc: xen-devel@lists.xenproject.org, Julien Grall , tim@xen.org, Jan Beulich , stefano.stabellini@citrix.com List-Id: xen-devel@lists.xenproject.org On 04/16/2015 10:55 AM, Ian Campbell wrote: > On Thu, 2015-04-09 at 16:09 +0100, Julien Grall wrote: >> From: Julien Grall > > I've left the XSM related quotes untrimmed and CCd Daniel. I think it's > all code motion (making x86 specific things generic), so perhaps no ack > needed but an opportunity to nack instead ;-) This seems correct to me. My initial thought when looking at this problem was that a distinct XSM hook for the ARM hypercall would be better, but other than the minor overhead from doing the IRQ label lookups twice, there is no real reason to prefer that method. This method has the advantage of not making more architecture-specific hooks which are sometimes harder to test/maintain. Acked-by: Daniel De Graaf