From: Jonathan Cameron <jic23@kernel.org>
To: Vlad Dogaru <vlad.dogaru@intel.com>, linux-iio@vger.kernel.org
Subject: Re: [PATCH 3/6] iio: sx9500: rename GPIO interrupt pin
Date: Sat, 18 Apr 2015 19:59:06 +0100 [thread overview]
Message-ID: <5532A97A.4090201@kernel.org> (raw)
In-Reply-To: <1428065254-6444-4-git-send-email-vlad.dogaru@intel.com>
On 03/04/15 13:47, Vlad Dogaru wrote:
> Signed-off-by: Vlad Dogaru <vlad.dogaru@intel.com>
For some reason I missed this before...
> ---
> drivers/iio/proximity/sx9500.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/proximity/sx9500.c b/drivers/iio/proximity/sx9500.c
> index 94c56f3..13b174c 100644
> --- a/drivers/iio/proximity/sx9500.c
> +++ b/drivers/iio/proximity/sx9500.c
> @@ -31,7 +31,8 @@
>
> #define SX9500_DRIVER_NAME "sx9500"
> #define SX9500_IRQ_NAME "sx9500_event"
> -#define SX9500_GPIO_NAME "sx9500_gpio"
> +
> +#define SX9500_GPIO_INT "interrupt"
You've changed the define as well as the name that broke the build so
I've changed it back again as a fix-up for this patch.
Your v3 patch 2 will uses the new name... I might fix it up
to change the name of the define there if I'm happy with the
rest of that patch.
J
>
> /* Register definitions. */
> #define SX9500_REG_IRQ_SRC 0x00
>
next prev parent reply other threads:[~2015-04-18 18:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-03 12:47 [PATCH 0/6] iio: sx9500: power and GPIO fixes Vlad Dogaru
2015-04-03 12:47 ` [PATCH 1/6] iio: sx9500: add power management Vlad Dogaru
2015-04-09 16:13 ` Jonathan Cameron
2015-04-03 12:47 ` [PATCH 2/6] iio: sx9500: optimize power usage Vlad Dogaru
2015-04-09 16:27 ` Jonathan Cameron
2015-04-10 10:36 ` Vlad Dogaru
2015-04-12 16:08 ` Jonathan Cameron
2015-04-03 12:47 ` [PATCH 3/6] iio: sx9500: rename GPIO interrupt pin Vlad Dogaru
2015-04-09 16:28 ` Jonathan Cameron
2015-04-18 18:59 ` Jonathan Cameron [this message]
2015-04-03 12:47 ` [PATCH 4/6] iio: sx9500: refactor GPIO interrupt code Vlad Dogaru
2015-04-09 16:30 ` Jonathan Cameron
2015-04-03 12:47 ` [PATCH 5/6] iio: sx9500: add GPIO reset pin Vlad Dogaru
2015-04-09 16:31 ` Jonathan Cameron
2015-04-03 12:47 ` [PATCH 6/6] iio: sx9500: fix formatting Vlad Dogaru
2015-04-09 16:31 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5532A97A.4090201@kernel.org \
--to=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=vlad.dogaru@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.