From mboxrd@z Thu Jan 1 00:00:00 1970 From: Takashi Sakamoto Subject: Re: [PATCH 1/2] ALSA: asound.h - use SNDRV_CTL_ELEM_ID_NAME_MAXLEN Date: Sun, 19 Apr 2015 13:55:46 +0900 Message-ID: <55333552.9040200@sakamocchi.jp> References: <1429291413-30668-1-git-send-email-vinod.koul@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from smtp301.phy.lolipop.jp (smtp301.phy.lolipop.jp [210.157.22.84]) by alsa0.perex.cz (Postfix) with ESMTP id 67A4E2606BC for ; Sun, 19 Apr 2015 06:55:52 +0200 (CEST) In-Reply-To: <1429291413-30668-1-git-send-email-vinod.koul@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Vinod Koul , alsa-devel@alsa-project.org Cc: liam.r.girdwood@linux.intel.com, tiwai@suse.de, broonie@kernel.org List-Id: alsa-devel@alsa-project.org On Apr 18 2015 02:23, Vinod Koul wrote: > we have defined SNDRV_CTL_ELEM_ID_NAME_MAXLEN as size of name array so use > this define instead of numeric value > > Signed-off-by: Vinod Koul > --- > include/uapi/sound/asound.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/uapi/sound/asound.h b/include/uapi/sound/asound.h > index 46145a5277fe..a45be6bdcf5b 100644 > --- a/include/uapi/sound/asound.h > +++ b/include/uapi/sound/asound.h > @@ -864,7 +864,7 @@ struct snd_ctl_elem_id { > snd_ctl_elem_iface_t iface; /* interface identifier */ > unsigned int device; /* device/client number */ > unsigned int subdevice; /* subdevice (substream) number */ > - unsigned char name[44]; /* ASCII name of item */ > + unsigned char name[SNDRV_CTL_ELEM_ID_NAME_MAXLEN]; /* ASCII name of item */ > unsigned int index; /* index of item */ > }; I think it better to post the same patch to alsa-lib when you add some changes to ALSA uapi headers because alsa-lib should also have the same headers. # I also realized that recent timestamping improvements are not still # included in alsa-lib header. Regards Takashi Sakamoto