From: Jonathan Cameron <jic23@kernel.org>
To: Daniel Baluta <daniel.baluta@intel.com>
Cc: sathyanarayanan.kuppuswamy@linux.intel.com, pmeerw@pmeerw.net,
linux-iio@vger.kernel.org, srinivas.pandruvada@linux.intel.com,
daniel.baluta@gmail.com
Subject: Re: [PATCH v7 0/2] Add support for LTR-301 and LTR-559 sensors
Date: Sun, 19 Apr 2015 14:04:48 +0100 [thread overview]
Message-ID: <5533A7F0.5090803@kernel.org> (raw)
In-Reply-To: <1429018642-4838-1-git-send-email-daniel.baluta@intel.com>
On 14/04/15 14:37, Daniel Baluta wrote:
> This patchset adds support for LiteOn LTR301 ambient light sensor
> and LTR559 ambient light and proximity sensor.
>
> v7:
> 1. Rebase LTR-301 on top of LTR-559 and merged the patches into a single patchset
> 2. Moved ltr501_chip_info_tbl below ltr501_info in patch 1 in order
> to make patch 2 changes look natural. :)
> 3. Moved "else" branch of id check from patch 2 to patch 1. Now it is no
> longer possible to have a NULL name after this check. If id is not NULL
> than id->name is one of ltr501_id already defined strings.
>
> v6:
> 1. Changed the title in commit log
>
> v5:
> 1. Rebased this patch on top of Daniel's LTR559 patchset
> (http://marc.info/?l=linux-kernel&m=142779827617036&w=2)
> 2. Added info and channel members to chip_info struture.
>
> v4:
> 1. Addressed minor comments from Peter Meerwald
> 2. Changed invalid chip id errno from ENOSYS to ENODEV
> 3. Fixed channel id index number
> 4. Removed unused variable.
>
> v3:
> 1. Sent v2 before by mistake. So sending the final version of v2 as v3.
>
> v2:
> 1. Handled device id NULL case in probe
> 2. Changed pr_warn to dev_warn
>
> v1:
> Extended LTR501 driver to support both LTR301 and LTR501 device.
>
> Daniel Baluta (1):
> iio: ltr501: Add support for ltr559 chip
>
> Kuppuswamy Sathyanarayanan (1):
> iio: ltr501: Add support for ltr301
>
> drivers/iio/light/Kconfig | 3 +-
> drivers/iio/light/ltr501.c | 240 ++++++++++++++++++++++++++++++++++++++-------
> 2 files changed, 209 insertions(+), 34 deletions(-)
>
Sorry Daniel, I've confused this further by first taking the set that added
interrupt support to this driver. Hence this series doesn't apply at all.
Don't suppose you could rebase on my testing branch to deal with that.
Sorry again, I was obviously half asleep and hadn't registered just how
much pain these two sets were going to cause.
Jonathan
next prev parent reply other threads:[~2015-04-19 13:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-14 13:37 [PATCH v7 0/2] Add support for LTR-301 and LTR-559 sensors Daniel Baluta
2015-04-14 13:37 ` [PATCH v7 1/2] iio: ltr501: Add support for ltr559 chip Daniel Baluta
2015-04-14 13:37 ` [PATCH v7 2/2] iio: ltr501: Add support for ltr301 Daniel Baluta
2015-04-19 13:04 ` Jonathan Cameron [this message]
2015-04-19 13:06 ` [PATCH v7 0/2] Add support for LTR-301 and LTR-559 sensors Jonathan Cameron
2015-04-19 13:19 ` Daniel Baluta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5533A7F0.5090803@kernel.org \
--to=jic23@kernel.org \
--cc=daniel.baluta@gmail.com \
--cc=daniel.baluta@intel.com \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.