From: Jonathan Cameron <jic23@kernel.org>
To: Daniel Baluta <daniel.baluta@intel.com>
Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org
Subject: Re: [PATCH 3/3] iio: magnetometer: Add ACPI support for MMC35240
Date: Sun, 19 Apr 2015 14:30:04 +0100 [thread overview]
Message-ID: <5533ADDC.5050203@kernel.org> (raw)
In-Reply-To: <1429095726-10055-4-git-send-email-daniel.baluta@intel.com>
On 15/04/15 12:02, Daniel Baluta wrote:
> We assume that ACPI device tables use MMC35240 to
> identify MEMSIC's 3 axis magnetic sensor.
>
> Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
Also fine, just wait for v2 of patch 1.
> ---
> drivers/iio/magnetometer/mmc35240.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/iio/magnetometer/mmc35240.c b/drivers/iio/magnetometer/mmc35240.c
> index 4c76938..8811714 100644
> --- a/drivers/iio/magnetometer/mmc35240.c
> +++ b/drivers/iio/magnetometer/mmc35240.c
> @@ -17,6 +17,7 @@
> #include <linux/i2c.h>
> #include <linux/delay.h>
> #include <linux/regmap.h>
> +#include <linux/acpi.h>
> #include <linux/pm.h>
>
> #include <linux/iio/iio.h>
> @@ -488,6 +489,12 @@ static const struct dev_pm_ops mmc35240_pm_ops = {
> SET_SYSTEM_SLEEP_PM_OPS(mmc35240_suspend, mmc35240_resume)
> };
>
> +static const struct acpi_device_id mmc35240_acpi_match[] = {
> + {"MMC35240", 0},
> + { },
> +};
> +MODULE_DEVICE_TABLE(acpi, mmc35240_acpi_match);
> +
> static const struct i2c_device_id mmc35240_id[] = {
> {"MMC35240", 0},
> {}
> @@ -498,6 +505,7 @@ static struct i2c_driver mmc35240_driver = {
> .driver = {
> .name = MMC35240_DRV_NAME,
> .pm = &mmc35240_pm_ops,
> + .acpi_match_table = ACPI_PTR(mmc35240_acpi_match),
> },
> .probe = mmc35240_probe,
> .remove = mmc35240_remove,
>
prev parent reply other threads:[~2015-04-19 13:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-15 11:02 [PATCH 0/3] Introduce support for MMC35240 magnetic sensor Daniel Baluta
2015-04-15 11:02 ` [PATCH 1/3] iio: magnetometer: Add support for MEMSIC MMC35240 sensor Daniel Baluta
2015-04-15 11:28 ` Peter Meerwald
2015-04-15 11:46 ` Daniel Baluta
2015-04-19 13:28 ` Jonathan Cameron
2015-04-24 16:00 ` Daniel Baluta
2015-04-24 16:14 ` Daniel Baluta
2015-04-15 11:02 ` [PATCH 2/3] iio: magnetometer: mmc35240: Add PM sleep support Daniel Baluta
2015-04-19 13:29 ` Jonathan Cameron
2015-04-15 11:02 ` [PATCH 3/3] iio: magnetometer: Add ACPI support for MMC35240 Daniel Baluta
2015-04-19 13:30 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5533ADDC.5050203@kernel.org \
--to=jic23@kernel.org \
--cc=daniel.baluta@intel.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.