All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: apw@canonical.com, davem@davemloft.net, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] checkpatch: suggest using eth_zero_addr() and eth_broadcast_addr()
Date: Mon, 20 Apr 2015 00:01:18 +0200	[thread overview]
Message-ID: <553425AE.909@gmail.com> (raw)
In-Reply-To: <1429474813.2947.34.camel@perches.com>

Hi Joe,

On 19.04.2015 22:20, Joe Perches wrote:
(...)
>> +# check for memset(foo, 0xFF, ETH_ALEN) that could be eth_broadcast_addr
>> +		if ($^V && $^V ge 5.10.0 &&
>> +			$line =~ /^\+(?:.*?)\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/s) {
> 
> Please align the $line with the $^V above it.

Thanks for review - I'll post v2 soon; 
Sorry for alignment issues - shame on me and my editor.

(I've found that PATCH 1/2 was also not aligned - will fix it as well)

Regards,
Mateusz

      reply	other threads:[~2015-04-19 22:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-19 19:04 [PATCH 0/2] checkpatch: new ethernet address manipulation checks Mateusz Kulikowski
2015-04-19 19:04 ` [PATCH 1/2] checkpatch: suggest using ether_addr_equal*() Mateusz Kulikowski
2015-04-19 20:23   ` Joe Perches
2015-04-19 19:04 ` [PATCH 2/2] checkpatch: suggest using eth_zero_addr() and eth_broadcast_addr() Mateusz Kulikowski
2015-04-19 20:20   ` Joe Perches
2015-04-19 22:01     ` Mateusz Kulikowski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=553425AE.909@gmail.com \
    --to=mateusz.kulikowski@gmail.com \
    --cc=apw@canonical.com \
    --cc=davem@davemloft.net \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.