From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qc0-f172.google.com (mail-qc0-f172.google.com [209.85.216.172]) by kanga.kvack.org (Postfix) with ESMTP id 207736B0032 for ; Sun, 19 Apr 2015 21:56:19 -0400 (EDT) Received: by qcbii10 with SMTP id ii10so51353328qcb.2 for ; Sun, 19 Apr 2015 18:56:18 -0700 (PDT) Received: from mail-qc0-x232.google.com (mail-qc0-x232.google.com. [2607:f8b0:400d:c01::232]) by mx.google.com with ESMTPS id 145si18294972qhu.43.2015.04.19.18.56.18 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 19 Apr 2015 18:56:18 -0700 (PDT) Received: by qcyk17 with SMTP id k17so51341493qcy.1 for ; Sun, 19 Apr 2015 18:56:18 -0700 (PDT) Message-ID: <55345cc1.0fc98c0a.1318.54fb@mx.google.com> Date: Sun, 19 Apr 2015 18:56:17 -0700 (PDT) From: Yasuaki Ishimatsu Subject: Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages() In-Reply-To: <55345756.40902@huawei.com> References: <5530E578.9070505@huawei.com> <5531679d.4642ec0a.1beb.3569@mx.google.com> <55345756.40902@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Xishi Qiu Cc: Andrew Morton , Yasuaki Ishimatsu , Kamezawa Hiroyuki , izumi.taku@jp.fujitsu.com, Tang Chen , Gu Zheng , Xiexiuqi , Mel Gorman , David Rientjes , Linux MM , LKML When hot adding memory and creating new node, the node is offline. And after calling node_set_online(), the node becomes online. Oh, sorry. I misread your ptaches. Thanks, Yasuaki Ishimatsu On Mon, 20 Apr 2015 09:33:10 +0800 Xishi Qiu wrote: > On 2015/4/18 4:05, Yasuaki Ishimatsu wrote: > > > > > Your patches will fix your issue. > > But, if BIOS reports memory first at node hot add, pgdat can > > not be initialized. > > > > Memory hot add flows are as follows: > > > > add_memory > > ... > > -> hotadd_new_pgdat() > > ... > > -> node_set_online(nid) > > > > When calling hotadd_new_pgdat() for a hot added node, the node is > > offline because node_set_online() is not called yet. So if applying > > your patches, the pgdat is not initialized in this case. > > > > Thanks, > > Yasuaki Ishimatsu > > > > Hi Yasuaki, > > I'm not quite understand, when BIOS reports memory first, why pgdat > can not be initialized? > When hotadd a new node, hotadd_new_pgdat() will be called too, and > when hotadd memory to a existent node, it's no need to call hotadd_new_pgdat(), > right? > > Thanks, > Xishi Qiu > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752903AbbDTB4V (ORCPT ); Sun, 19 Apr 2015 21:56:21 -0400 Received: from mail-qc0-f174.google.com ([209.85.216.174]:36558 "EHLO mail-qc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752131AbbDTB4S (ORCPT ); Sun, 19 Apr 2015 21:56:18 -0400 Message-ID: <55345cc1.0fc98c0a.1318.54fb@mx.google.com> Date: Sun, 19 Apr 2015 18:56:17 -0700 (PDT) From: Yasuaki Ishimatsu To: Xishi Qiu Cc: Andrew Morton , Yasuaki Ishimatsu , Kamezawa Hiroyuki , , Tang Chen , Gu Zheng , Xiexiuqi , Mel Gorman , David Rientjes , Linux MM , LKML Subject: Re: [PATCH 1/2 V2] memory-hotplug: fix BUG_ON in move_freepages() In-Reply-To: <55345756.40902@huawei.com> References: <5530E578.9070505@huawei.com> <5531679d.4642ec0a.1beb.3569@mx.google.com> <55345756.40902@huawei.com> X-Mailer: Sylpheed 3.4.2 (GTK+ 2.10.14; i686-pc-mingw32) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When hot adding memory and creating new node, the node is offline. And after calling node_set_online(), the node becomes online. Oh, sorry. I misread your ptaches. Thanks, Yasuaki Ishimatsu On Mon, 20 Apr 2015 09:33:10 +0800 Xishi Qiu wrote: > On 2015/4/18 4:05, Yasuaki Ishimatsu wrote: > > > > > Your patches will fix your issue. > > But, if BIOS reports memory first at node hot add, pgdat can > > not be initialized. > > > > Memory hot add flows are as follows: > > > > add_memory > > ... > > -> hotadd_new_pgdat() > > ... > > -> node_set_online(nid) > > > > When calling hotadd_new_pgdat() for a hot added node, the node is > > offline because node_set_online() is not called yet. So if applying > > your patches, the pgdat is not initialized in this case. > > > > Thanks, > > Yasuaki Ishimatsu > > > > Hi Yasuaki, > > I'm not quite understand, when BIOS reports memory first, why pgdat > can not be initialized? > When hotadd a new node, hotadd_new_pgdat() will be called too, and > when hotadd memory to a existent node, it's no need to call hotadd_new_pgdat(), > right? > > Thanks, > Xishi Qiu >