From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [PATCH 1/8] raisin: Fix non-verbose case
Date: Mon, 20 Apr 2015 09:49:52 +0100
Message-ID: <5534BDB0.7040800@eu.citrix.com>
References: <1429201182-1044-1-git-send-email-george.dunlap@eu.citrix.com>
	<alpine.DEB.2.02.1504171104280.7690@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <alpine.DEB.2.02.1504171104280.7690@kaball.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 04/17/2015 11:06 AM, Stefano Stabellini wrote:
> On Thu, 16 Apr 2015, George Dunlap wrote:
>> Because we use "set -e", we can't use the "a && b" construct, as it will fail and stop the script.
>>
>> Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
> 
> I am wondering whether we should ban both a && b and a || b from the
> code and just go with the more verbose but also harder to get wrong:
> 
> if [[ $VERBOSE -eq 1 ]]
> then
>     echo calling "$component"_"$1"
> fi
> 
> Reading the code and seeing a || b will tempt you into writing a && b.

That's a good point. :-)  Do you want to go it or shall I resend?

 -George