From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [PATCH 6/8] raisin: Break build into components and
 allow the sub-steps to be called individually
Date: Mon, 20 Apr 2015 10:05:37 +0100
Message-ID: <5534C161.7010800@eu.citrix.com>
References: <1429201182-1044-1-git-send-email-george.dunlap@eu.citrix.com>
	<1429201182-1044-6-git-send-email-george.dunlap@eu.citrix.com>
	<alpine.DEB.2.02.1504171116390.7690@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <alpine.DEB.2.02.1504171116390.7690@kaball.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 04/17/2015 11:18 AM, Stefano Stabellini wrote:
> On Thu, 16 Apr 2015, George Dunlap wrote:
>> This makes it easier to debug just one aspect of the build.
>>
>> Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
>> ---
>> CC: Stefano Stabellini <stefano.stabellini@citrix.com>
>> ---
>>  lib/commands.sh | 16 ++++++++++++----
>>  raise           |  2 +-
>>  2 files changed, 13 insertions(+), 5 deletions(-)
>>
>> diff --git a/lib/commands.sh b/lib/commands.sh
>> index 17e2129..c5df9ad 100755
>> --- a/lib/commands.sh
>> +++ b/lib/commands.sh
>> @@ -45,17 +45,25 @@ function install-builddep() {
>>      YES=y check-builddep
>>  }
>>  
>> -function build() {
>> -    check-builddep
>> -    
>> +function build-only() {
>>      mkdir -p "$INST_DIR" &>/dev/null
>>  
>>      # build and install under $DESTDIR
>>      for_each_component build
>> -    
>> +}
>> +
>> +function build-package() {
>>      build_package xen-system
>>  }
>>  
>> +function build() {
>> +    check-builddep
>> +
>> +    build-only
>> +
>> +    build-package
>> +}
>> +
>>  function unraise() {
>>      for_each_component clean
>>  
>> diff --git a/raise b/raise
>> index bce6908..59de04a 100755
>> --- a/raise
>> +++ b/raise
>> @@ -64,7 +64,7 @@ do
>>  done
>>  
>>  case "$1" in
>> -    "install-builddep" | "build" | "install" | "configure" | "unraise" )
>> +    "install-builddep" | "build" | "build-only" | "build-package" | "install" | "configure" | "unraise" )
>>          COMMAND=$1
>>          ;;
>>      *)
> 
> You have added two new commands, but they are not documented in the help
> function or in the README. As they stand they are "hidden" commands. Is
> that on purpose because they are supposed to be used just for debugging?
> Maybe it would be worth documenting debugging functions too somewhere.

No, they were meant to be visible.  I'll document them.

 -George