From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?windows-1252?Q?Gustau_P=E9rez?= Subject: Re: [PATCH] Do not assume mtu the mtu of xnb and mtu interfaces on FreeBSD. Date: Mon, 20 Apr 2015 12:21:27 +0200 Message-ID: <5534D327.8050007@gmail.com> References: <1429513972-3834-1-git-send-email-gustau.perez@gmail.com> <5534C610.2000902@citrix.com> <20150420100159.GF20027@zion.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Yk8pX-0003CU-F0 for xen-devel@lists.xenproject.org; Mon, 20 Apr 2015 10:21:31 +0000 Received: by wgsk9 with SMTP id k9so173389078wgs.3 for ; Mon, 20 Apr 2015 03:21:29 -0700 (PDT) In-Reply-To: <20150420100159.GF20027@zion.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Wei Liu , =?windows-1252?Q?Roger_Pau_Monn=E9?= Cc: xen-devel@lists.xenproject.org, Ian Jackson , Ian Campbell List-Id: xen-devel@lists.xenproject.org On 20/04/2015 12:01, Wei Liu wrote: > On Mon, Apr 20, 2015 at 11:25:36AM +0200, Roger Pau Monn=E9 wrote: >> El 20/04/15 a les 9.12, Gustau Perez ha escrit: >>> On creation time, tap and xnb interfaces are created with an mtu of >>> 1500 bytes, assuming the bridge will have the same value. >>> Instead, check the bridge mtu and configure the new xnb or >>> tap interface with the same value. >>> >>> The tools used are sed and ifconfig, both included on base. No need >>> to install additional ports (no new dependences). >>> >>> Signed-off-by: Gustau Perez >> Acked-by: Roger Pau Monn=E9 >> >> +CCing the tools maintainers. >> > The patch title is a bit cryptic. Maybe change it to: > > hotplug: set network interface MTU to bridge MTU on FreeBSD > > ? > > In any case > > Acked-by: Wei Liu > > Wei. Seems fine to me. Best, G.