From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?windows-1252?Q?Radek_Dost=E1l?= Subject: Re: [PATCHv2] drm: fb_helper: prefer to use mode, which is not DRM_MODE_TYPE_USERDEF Date: Mon, 20 Apr 2015 12:38:25 +0200 Message-ID: <5534D721.1060206@radekdostal.com> References: <1429477553-10294-1-git-send-email-rd@radekdostal.com> <1429507593-21172-1-git-send-email-rd@radekdostal.com> <20150420090929.GC25451@nuc-i3427.alporthouse.com> <5534C884.8080101@radekdostal.com> <20150420094608.GD25451@nuc-i3427.alporthouse.com> <20150420095818.GE25451@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150420095818.GE25451@nuc-i3427.alporthouse.com> Sender: linux-kernel-owner@vger.kernel.org To: Chris Wilson , airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org Hi Chris, On 04/20/2015 11:58 AM, Chris Wilson wrote: > Hmm, so that should be before the clock comparison as well to fix your > example. Not as neat. indeed that is required. > The other idea I was considering was not adding the GTF cmdline mode if > the probed modes already contain one of a matching resolution. The goal > here is to also not present a mode to userspace that is invalid. Unfortunately you can not do that. I already tried. At the time when drm_helper_probe_add_cmdline_mode is called EDID informations are not yet available. Only option would be to remove the GTF cmdline mode, when matching mode is found in EDID. Thanks, Radek