From mboxrd@z Thu Jan  1 00:00:00 1970
From: George Dunlap <george.dunlap@eu.citrix.com>
Subject: Re: [PATCH 8/8] raisin: RFC Add blktap2 as an external
	tree
Date: Mon, 20 Apr 2015 11:59:36 +0100
Message-ID: <5534DC18.1010609@eu.citrix.com>
References: <1429201182-1044-1-git-send-email-george.dunlap@eu.citrix.com>
	<1429201182-1044-8-git-send-email-george.dunlap@eu.citrix.com>
	<alpine.DEB.2.02.1504171157440.7690@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <alpine.DEB.2.02.1504171157440.7690@kaball.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@citrix.com>, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 04/17/2015 11:58 AM, Stefano Stabellini wrote:
> On Thu, 16 Apr 2015, George Dunlap wrote:
>> Until we start hosting the blktap repo on xenbits, use the one from github.
>>
>> Also, we need to pass in the directories where to find the
>> libblktapctl headers in the Xen build.
>>
>> Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
>> ---
>> Note: For now use the "upstream" XenServer repo.
>>
>> Also, to build with this you need the patches to allow Xen to use an out-of-tree blktap,
>> which can be found here:
>>
>> git://xenbits.xen.org/people/gdunlap/xen.git  out/blktap25/rfc-v2
>>
>> CC: Stefano Stabellini <stefano.stabellini@citrix.com>
>> ---
>>  components/blktap | 47 +++++++++++++++++++++++++++++++++++++++++++++++
>>  components/series |  1 +
>>  components/xen    |  5 +++++
>>  defconfig         |  9 ++++++---
>>  4 files changed, 59 insertions(+), 3 deletions(-)
>>  create mode 100644 components/blktap
>>
>> diff --git a/components/blktap b/components/blktap
>> new file mode 100644
>> index 0000000..3062b2a
>> --- /dev/null
>> +++ b/components/blktap
>> @@ -0,0 +1,47 @@
>> +#!/usr/bin/env bash
>> +
>> +function blktap_check_package() {
>> +    local DEP_Debian_common="build-essential autoconf libtool tar libaio-dev uuid-dev openssl-dev"
>> +    local DEP_Debian_x86_32="$DEP_Debian_common"
>> +    local DEP_Debian_x86_64="$DEP_Debian_x86_32"
>> +    local DEP_Debian_arm32="$DEP_Debian_common"
>> +    local DEP_Debian_arm64="$DEP_Debian_arm32"
>> +
>> +    local DEP_Fedora_common="make gcc python-devel autoconf libtool tar file libaio-devel libuuid-devel openssl-devel"
>> +    local DEP_Fedora_x86_32="$DEP_Fedora_common"
>> +    local DEP_Fedora_x86_64="$DEP_Fedora_x86_32"
>> +
>> +    local DEP_CentOS_common="make gcc python-devel autoconf libtool tar file libaio-devel libuuid-devel openssl-devel"
>> +    local DEP_CentOS_x86_32="$DEP_Redhat_common"
>> +    local DEP_CentOS_x86_64="$DEP_Redhat_x86_32"
>> +
>> +    echo Checking blktap dependencies
>> +    eval check-package \$DEP_"$DISTRO"_"$ARCH"
>> +}
>> +
>> +function blktap_build() {
>> +    cd "$BASEDIR"
>> +    git-checkout $BLKTAP_URL $BLKTAP_REVISION blktap-dir
>> +    cd blktap-dir
>> +    ./autogen.sh
>> +    ./configure --prefix=$PREFIX
>> +    $MAKE
>> +    $MAKE install DESTDIR="$INST_DIR"
>> +    cd "$BASEDIR"
>> +}
> 
> I think we need to disable the build on architectures other than x86,
> see grub for example

Do we?  There's no reason a blktap2 kernel module couldn't be built on
ARM, is there?

And in any case the long-term plan is to get blktap3 working as well,
which doesn't require kernel-space drivers.

Or do you mean on systems other than Linux?

 -George