From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 2/7] docs/build: Do not open-code $*
Date: Mon, 20 Apr 2015 12:55:58 +0100
Message-ID: <5534E94E.3020709@citrix.com>
References: <1429526966-18874-1-git-send-email-andrew.cooper3@citrix.com>
	<1429526966-18874-3-git-send-email-andrew.cooper3@citrix.com>
	<553503A30200007800073BA2@mail.emea.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <553503A30200007800073BA2@mail.emea.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>, Wei Liu <wei.liu2@citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 20/04/15 12:48, Jan Beulich wrote:
>>>> On 20.04.15 at 12:49, <andrew.cooper3@citrix.com> wrote:
>> --- a/docs/Makefile
>> +++ b/docs/Makefile
>> @@ -73,13 +73,11 @@ endif
>>  
>>  man1/%.1: man/%.pod.1 Makefile
>>  	$(INSTALL_DIR) $(@D)
>> -	$(POD2MAN) --release=$(VERSION) --name=`echo $@ | sed 's/^man1.//'| \
>> -		sed 's/.1//'` -s 1 -c "Xen" $< $@
>> +	$(POD2MAN) --release=$(VERSION) --name=$* -s 1 -c "Xen" $< $@
> This is a change in quoting, and while benign now maybe it would be
> better to add back quotation marks?

Are you sure? The result of the `` was not previously quoted, which is
why I left it unquoted across the change.

If quoting were an issue, all rules would need updating for $*, $< and $@

~Andrew