From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH 6/7] docs/build: Move install checks into individual build targets Date: Mon, 20 Apr 2015 13:01:25 +0100 Message-ID: <5534EA95.6080107@citrix.com> References: <1429526966-18874-1-git-send-email-andrew.cooper3@citrix.com> <1429526966-18874-7-git-send-email-andrew.cooper3@citrix.com> <553505C90200007800073BB5@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <553505C90200007800073BB5@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: Ian Jackson , Wei Liu , Ian Campbell , Xen-devel List-Id: xen-devel@lists.xenproject.org On 20/04/15 12:57, Jan Beulich wrote: >>>> On 20.04.15 at 12:49, wrote: >> @@ -103,12 +88,20 @@ install: install-man-pages install-html >> >> # Individual file build targets >> man1/%.1: man/%.pod.1 Makefile >> +ifdef POD2MAN > Perhaps better to use ifneq($(POD2MAN),) in such cases? I was following the prevailing style, but can update all instances. FWIW, it is not currently an issue. > >> @$(INSTALL_DIR) $(@D) >> $(POD2MAN) --release=$(VERSION) --name=$* -s 1 -c "Xen" $< $@ >> +else >> + @echo "pod2man not installed; skipping $(@F)" > Why do you strip off the directory part? Leaving it in place would > make the output even less ambiguous (and hence more helpful). Can do. ~Andrew