On 20/04/15 14:12, Sven Eckelmann wrote:
> Can you also check the "weird" patch which is in the release since 2014.2.0
> but doesn't seem to be in net-next.git/linux.git?
> 
> http://git.open-mesh.org/batman-adv.git/commit/31f391475cc08724e96ab060ef4aa6503d11da8e

Why this patch is not upstream I don't know - it made its way through my
pipe to net-next, but probably was never sent.

However, after re-reading this patch and quickly testing the current
behaviour with linux-4.0 I have some doubts about its usefulness.

The problem I tried to fix with this patch started by observing that
when changing the MAC address of a soft-iface VLAN (e.g. bat0.2)
ndo_set_mac_address() seemed not to be called.
Therefore with this patch I change the no-purge MAC addresses in the
local translation table when the MAC address of bat0 got changed.


I think we would need to investigate a bit more if this is still true or
not and then decide to revert or not this patch (in the latter case I
will send it to net-next).

A test that could be done consists in checking if ndo_set_mac_address()
gets invoked when changing the MAC address of any bat0.x interface.

Cheers,


-- 
Antonio Quartulli