Re: [PATCH RESEND v6 2/2] leds: tlc591xx: Driver for the TI 8/16 Channel i2c LED driver

[Jacek Anaszewski <j.anaszewski@samsung.com>]

On 04/20/2015 01:59 PM, Andrew Lunn wrote:
> On Mon, Apr 20, 2015 at 11:06:09AM +0200, Jacek Anaszewski wrote:
>> Hi Andrew,
>>
>> Very nice driver.
>
> Thanks. I just hope it gets accepted into this merge window.
>
>> I have one question below.
>
[...]
>>> +static int
>>> +tlc591xx_configure(struct device *dev,
>>> +		   struct tlc591xx_priv *priv,
>>> +		   const struct tlc591xx *tlc591xx)
>>> +{
>>> +	unsigned int i;
>>> +	int err = 0;
>>> +
>>> +	tlc591xx_set_mode(priv->regmap, MODE2_DIM);
>>
>> It seems that all leds will be initially turned on, in dim mode.
>> This shouldn't be fixed and probably an optional 'led-mode' DT node
>> property should be provided for defining the initial state. It would
>> default to OFF if not present.
>
> If you look further down, you will find
>
>>> +		priv->leds[reg].ldev.default_trigger =
>>> +			of_get_property(child, "linux,default-trigger", NULL);
>
> This is the normal way in DT to specify the default on/off/keep
> current value/heartbeat etc.

OK, I was initially thinking that initializing LED to MODE2_DIM
turns the LED on.

Acked-by: Jacek Anaszewski <j.anaszewski@samsung.com>


-- 
Best Regards,
Jacek Anaszewski