From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH V15 5/9] xen: Make gpfn related memops compatible with wider return values Date: Mon, 20 Apr 2015 16:22:29 +0100 Message-ID: <553519B5.8090202@citrix.com> References: <1429542384-23905-1-git-send-email-tklengyel@sec.in.tum.de> <1429542384-23905-6-git-send-email-tklengyel@sec.in.tum.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1429542384-23905-6-git-send-email-tklengyel@sec.in.tum.de> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tamas K Lengyel , xen-devel@lists.xen.org Cc: wei.liu2@citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, tim@xen.org, julien.grall@linaro.org, ian.jackson@eu.citrix.com, stefano.stabellini@citrix.com, keir@xen.org List-Id: xen-devel@lists.xenproject.org On 20/04/15 16:06, Tamas K Lengyel wrote: > The current implementation of three memops, XENMEM_current_reservation, > XENMEM_maximum_reservation and XENMEM_maximum_gpfn return values as an > int. However, in ARM64 we could potentially have 36-bit pfn's, thus > in preparation for the ARM patch, in this patch we update the existing > memop routines to use a struct, xen_get_gpfn, to exchange the gpfn info > as a uin64_t. > > This patch also adds error checking on the toolside in case the memop > fails. > > Signed-off-by: Tamas K Lengyel XENMEM, unlikely domctls/sysctls is a guest-visible stable ABI/API. You cannot make adjustments like this, but you can add a brand new op with appropriate parameters and list the old ops as deprecated. ~Andrew