From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 00/18] virtio-blk: Support "VIRTIO_CONFIG_S_NEEDS_RESET" Date: Mon, 20 Apr 2015 21:10:02 +0200 Message-ID: <55354F0A.5080809@redhat.com> References: <1429257573-7359-1-git-send-email-famz@redhat.com> <20150420175905-mutt-send-email-mst@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20150420175905-mutt-send-email-mst@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org To: "Michael S. Tsirkin" , Fam Zheng Cc: "Aneesh Kumar K.V" , Amit Shah , qemu-devel@nongnu.org, Stefan Hajnoczi , virtualization@lists.linux-foundation.org List-Id: virtualization@lists.linuxfoundation.org On 20/04/2015 19:36, Michael S. Tsirkin wrote: > At the implementation level, there's one big issue you seem to have > missed: DMA to invalid memory addresses causes a crash in memory core. > I'm not sure whether it makes sense to recover from virtio core bugs > when we can't recover from device bugs. What do you mean exactly? DMA to invalid memory addresses causes address_space_map to return a "short read". Paolo From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46725) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YkHAQ-0005d5-3u for qemu-devel@nongnu.org; Mon, 20 Apr 2015 15:15:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YkHAM-0004nu-Oy for qemu-devel@nongnu.org; Mon, 20 Apr 2015 15:15:38 -0400 Received: from mail-wi0-x236.google.com ([2a00:1450:400c:c05::236]:33851) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YkH55-0003U2-H0 for qemu-devel@nongnu.org; Mon, 20 Apr 2015 15:10:07 -0400 Received: by wicmx19 with SMTP id mx19so47257470wic.1 for ; Mon, 20 Apr 2015 12:10:07 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <55354F0A.5080809@redhat.com> Date: Mon, 20 Apr 2015 21:10:02 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1429257573-7359-1-git-send-email-famz@redhat.com> <20150420175905-mutt-send-email-mst@redhat.com> In-Reply-To: <20150420175905-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 00/18] virtio-blk: Support "VIRTIO_CONFIG_S_NEEDS_RESET" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , Fam Zheng Cc: "Aneesh Kumar K.V" , Amit Shah , qemu-devel@nongnu.org, Stefan Hajnoczi , virtualization@lists.linux-foundation.org On 20/04/2015 19:36, Michael S. Tsirkin wrote: > At the implementation level, there's one big issue you seem to have > missed: DMA to invalid memory addresses causes a crash in memory core. > I'm not sure whether it makes sense to recover from virtio core bugs > when we can't recover from device bugs. What do you mean exactly? DMA to invalid memory addresses causes address_space_map to return a "short read". Paolo