All of lore.kernel.org
 help / color / mirror / Atom feed
From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] MPC8541/MPC8555: Enable SS_EN in DDR_SDRAM_CLK_CNLT register
Date: Mon, 20 Apr 2015 13:56:44 -0700	[thread overview]
Message-ID: <5535680C.3030906@freescale.com> (raw)
In-Reply-To: <1423853831-17729-1-git-send-email-curt@cumulusnetworks.com>


On 02/13/2015 10:57 AM, Curt Brune wrote:
> According to the MPC8555/MPC8541 reference manual the SS_EN (source
> synchronous enable) bit in the DDR_SDRAM_CLK_CNLT register must be set
> during initialization.
> 
> From section 9.4.1.8 of that manual:
> 
>    Source synchronous enable. This bit field must be set during
>    initialization. See Section 9.6.1, "DDR SDRAM Initialization
>    Sequence," details.
> 
>    0 - Reserved
>    1 - The address and command are sent to the DDR SDRAMs source
>        synchronously.
> 
> In addition, Freescale application note AN2805 is also very clear that
> this bit must be set.
> 
> This patch reverts a change introduced by commit
> 457caecdbca3df21a93abff19eab12dbc61b7897.
> 
> Testing Done:
> 
> Compiled targets CONFIG_TARGET_MPC8555CDS and CONFIG_TARGET_MPC8541CDS
> and inspected the generated assembly code to verify the SS_EN bit was being
> set.  There is one extra instruction emitted:
> 
>   fff9b774: 65 29 80 00  oris    r9,r9,32768
> 
> Compiled the CONFIG_TARGET_MPC8548CDS target and verified that no
> additional instructions were emitted related to this patch.
> 
> Booted an image on a MPC8541 based board successfully.
> 
> Signed-off-by: Curt Brune <curt@cumulusnetworks.com>
> ---

Applied to mpc85xx master, awaiting upstream.

York

      parent reply	other threads:[~2015-04-20 20:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-13 18:57 [U-Boot] [PATCH 1/1] MPC8541/MPC8555: Enable SS_EN in DDR_SDRAM_CLK_CNLT register Curt Brune
2015-02-13 19:01 ` York Sun
2015-04-20 20:56 ` York Sun [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5535680C.3030906@freescale.com \
    --to=yorksun@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.