All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wang Nan <wangnan0@huawei.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: <acme@kernel.org>, <jolsa@kernel.org>, <mingo@redhat.com>,
	<lizefan@huawei.com>, <pi3orama@163.com>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf: annotate: make it respect -i option.
Date: Tue, 21 Apr 2015 11:06:48 +0800	[thread overview]
Message-ID: <5535BEC8.20008@huawei.com> (raw)
In-Reply-To: <20150402081231.GC23913@sejong>

On 2015/4/2 16:12, Namhyung Kim wrote:
> On Thu, Apr 02, 2015 at 06:04:52AM +0000, Wang Nan wrote:
>> There is a bug in perf annotate that it doesn't respect user provided
>> '-i'/'--input' option:
>>
>>  # perf record ls
>>    [ perf record: Woken up 1 times to write data ]
>>    [ perf record: Captured and wrote 0.001 MB perf.data (8 samples) ]
>>  # mv ./perf.data ./perf.data.new
>>  # perf annotate -i ./perf.data.new  --stdio
>>    failed to open perf.data: No such file or directory  (try 'perf record' first)
>>
>> This patch fix it by setting file path after option parsing, like
>> what 'perf report' does.
>>
>> Signed-off-by: Wang Nan <wangnan0@huawei.com>
> 
> I guess other commands are also suffered from this bug.. anyway,
> 
> Acked-by: Namhyung Kim <namhyung@kernel.org>
> 
> Thanks,
> Namhyung
> 

Hi,

Looks like the next patch 'perf kmem: Respect -i option' has already been collected
by tip/master, but this patch is lost. Is there any problem?

Thank you!



  reply	other threads:[~2015-04-21  3:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-02  6:04 [PATCH] perf: annotate: make it respect -i option Wang Nan
2015-04-02  8:12 ` Namhyung Kim
2015-04-21  3:06   ` Wang Nan [this message]
2015-04-02  8:24 ` [PATCH] perf kmem: Respect " Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5535BEC8.20008@huawei.com \
    --to=wangnan0@huawei.com \
    --cc=acme@kernel.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizefan@huawei.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=pi3orama@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.