From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Jyri Sarha <jsarha@ti.com>, alsa-devel@alsa-project.org
Cc: liam.r.girdwood@linux.intel.com, misael.lopez@ti.com,
broonie@kernel.org, dan.carpenter@oracle.com
Subject: Re: [PATCH 0/2] Calculate BCLK using TDM slots and remove channels rule
Date: Tue, 21 Apr 2015 09:30:37 +0300 [thread overview]
Message-ID: <5535EE8D.4030302@ti.com> (raw)
In-Reply-To: <cover.1429537509.git.jsarha@ti.com>
On 04/20/2015 04:58 PM, Jyri Sarha wrote:
> The first patch is a bugfix. I did not have the HW see the problem
> myself, but reading from the code the problem is evident. This should
> also fix Dan Carpenter's concern about stack usage in
> davinci_mcasp_hw_rule_channels(), as the whole function is removed.
>
> The second patch is just an optimization of the sample-rate rule. In
> effect I put in use Takashi Iwai's suggestion for fixing the stack
> usage issue in the channels rule.
Both:
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
>
> Jyri Sarha (2):
> ASoC: davinci-mcasp: Calculate BCLK using TDM slots and remove
> channels rule
> ASoC: davinci-macsp: Optimize implicit BLCK sample-rate rule
>
> sound/soc/davinci/davinci-mcasp.c | 104 ++++++++++----------------------------
> 1 file changed, 27 insertions(+), 77 deletions(-)
>
--
Péter
next prev parent reply other threads:[~2015-04-21 6:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-20 13:58 [PATCH 0/2] Calculate BCLK using TDM slots and remove channels rule Jyri Sarha
2015-04-20 13:58 ` [PATCH 1/2] ASoC: davinci-mcasp: " Jyri Sarha
2015-04-20 13:58 ` [PATCH 2/2] ASoC: davinci-macsp: Optimize implicit BLCK sample-rate rule Jyri Sarha
2015-04-21 6:30 ` Peter Ujfalusi [this message]
2015-04-22 7:44 ` [PATCH 0/2] Calculate BCLK using TDM slots and remove channels rule Jyri Sarha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5535EE8D.4030302@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=jsarha@ti.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=misael.lopez@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.