From: Michael J Gruber <git@drmicha.warpmail.net>
To: Junio C Hamano <gitster@pobox.com>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: Tim Friske <me@tifr.de>, git <git@vger.kernel.org>
Subject: Re: Why does "git log -G<regex>" works with "regexp-ignore-case" but not with other regexp-related options?
Date: Tue, 21 Apr 2015 10:41:33 +0200 [thread overview]
Message-ID: <55360D3D.3010201@drmicha.warpmail.net> (raw)
In-Reply-To: <xmqqtwwaljwb.fsf@gitster.dls.corp.google.com>
Junio C Hamano venit, vidit, dixit 20.04.2015 20:44:
> Linus Torvalds <torvalds@linux-foundation.org> writes:
>
>> And to clarify: I don't suggest always building with libpcre. I
>> literally suggest having something like
>>
>> /* hacky mac-hack hack */
>> if (strncmp("(?i)", p->pattern, 4)) {
>> p->pattern += 4;
>> p->ignore_case = true;
>> }
>>
>> just in front of the "regcomp() call, and nothing more fancy than that.
>
> Yeah, looking at the way grep.c:compile_regexp() is structured, we
> are already prepared to allow
>
> $ git log --grep='(?i)torvalds' --grep='Linus'
>
> that wants to find one piece of text case insensitively while
> another case sensitively in the same text (i.e. the log message
> part), so per-pattern customization may be a good way to do this.
>
And '(?f)foo' switches to fixed strings ;)
We have engine-switching options and engine-modification options. The
latter are certainly good in the expression itself. Maybe even the
former, though I don't know how to switch away from fixed-strings in
that way...
I had forgotten about pcre. Maybe switching options independently is so
unusual that "use pcre" is good enough as a solution to suggest to those
few users?
In any case, that leaves us with:
- resolve the existing inconsistencies around --regexp-ignore-case
- allow to switch the engine for all greppy operations
Maybe have all command line options apply to all greppy ops as a first
step, which allows pcre and thus '(?i)' for all fields?
Michael
next prev parent reply other threads:[~2015-04-21 8:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-17 10:00 Why does "git log -G<regex>" works with "regexp-ignore-case" but not with other regexp-related options? Tim Friske
2015-04-17 14:26 ` Michael J Gruber
2015-04-17 16:18 ` Junio C Hamano
2015-04-17 17:09 ` Junio C Hamano
2015-04-17 17:45 ` Junio C Hamano
2015-04-20 8:49 ` Michael J Gruber
2015-04-20 17:41 ` Junio C Hamano
2015-04-20 18:33 ` Linus Torvalds
2015-04-20 18:44 ` Junio C Hamano
2015-04-21 8:41 ` Michael J Gruber [this message]
2015-04-21 16:59 ` Junio C Hamano
2015-04-22 9:08 ` Michael J Gruber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55360D3D.3010201@drmicha.warpmail.net \
--to=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=me@tifr.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.