All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Abbott <abbotti@mev.co.uk>
To: Greg KH <gregkh@linuxfoundation.org>,
	Gbenga Adalumo <gbengadev@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: comedi: fix coding style errors in daqboard2000.c
Date: Tue, 21 Apr 2015 10:14:46 +0100	[thread overview]
Message-ID: <55361506.6000809@mev.co.uk> (raw)
In-Reply-To: <20150421075005.GB10367@kroah.com>

On 21/04/15 08:50, Greg KH wrote:
> On Mon, Apr 20, 2015 at 07:57:31PM -0700, Gbenga Adalumo wrote:
>> The patch fixes a trailing whitespace and code indenting coding style
>> errors as reported by checkpatch.pl tool.
>>   Details of the lines where the fixed errors were reported are as follows:
>>
>> drivers/staging/comedi/drivers/daqboard2000.c:43: ERROR: trailing whitespace
>> drivers/staging/comedi/drivers/daqboard2000.c:46: ERROR: code indent
>> should use tabs where possible
>
> <snip>
>
> You don't have to list all of the individual errors, and not in a
> line-wrapped way either.
>
> It looks like you are fixing different types of errors, so please
> provide different patches to do them.  Each patch should just do one
> thing.

All these "errors" occur in a single block comment.  It would be 
preferable if that block comment were reformatted to use the usual 
block-comment style:

/*
  * blah
  * blah
  */

This has already been done for some comedi drivers.

Thanks,
Ian A.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@mev.co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-

  reply	other threads:[~2015-04-21  9:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-20  2:59 [PATCH] Staging: comedi: fix coding style errors in daqboard2000.c Gbenga Adalumo
2015-04-20 14:43 ` Greg KH
2015-04-21  2:57   ` Gbenga Adalumo
2015-04-21  7:50     ` Greg KH
2015-04-21  9:14       ` Ian Abbott [this message]
2015-04-21  9:09     ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55361506.6000809@mev.co.uk \
    --to=abbotti@mev.co.uk \
    --cc=devel@driverdev.osuosl.org \
    --cc=gbengadev@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.