From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Tue, 21 Apr 2015 11:38:23 +0200 (CEST) Received: from mailapp01.imgtec.com ([195.59.15.196]:18102 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27011376AbbDUJiTqdHWv (ORCPT ); Tue, 21 Apr 2015 11:38:19 +0200 Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35]) by Websense Email Security Gateway with ESMTPS id 33933C468FC8E; Tue, 21 Apr 2015 10:38:13 +0100 (IST) Received: from LEMAIL01.le.imgtec.org (192.168.152.62) by KLMAIL01.kl.imgtec.org (192.168.5.35) with Microsoft SMTP Server (TLS) id 14.3.195.1; Tue, 21 Apr 2015 10:38:15 +0100 Received: from [192.168.154.117] (192.168.154.117) by LEMAIL01.le.imgtec.org (192.168.152.62) with Microsoft SMTP Server (TLS) id 14.3.210.2; Tue, 21 Apr 2015 10:38:15 +0100 Message-ID: <55361A86.9060000@imgtec.com> Date: Tue, 21 Apr 2015 10:38:14 +0100 From: Markos Chandras User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Huacai Chen , Ralf Baechle CC: "Steven J. Hill" , , Fuxin Zhang , Zhangjin Wu , "Kelvin Cheung" Subject: Re: [PATCH V2] MIPS: Loongson: Naming style cleanup and rework References: <1429581635-26476-1-git-send-email-chenhc@lemote.com> In-Reply-To: <1429581635-26476-1-git-send-email-chenhc@lemote.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.117] Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 46954 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: Markos.Chandras@imgtec.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips Hi, On 04/21/2015 03:00 AM, Huacai Chen wrote: > Currently, code of Loongson-2/3 is under loongson directory and code of > Loongson-1 is under loongson1 directory. Besides, there are Kconfig > options such as MACH_LOONGSON and MACH_LOONGSON1. This naming style is > very ugly and confusing. Since Loongson-2/3 are both 64-bit general- > purpose CPU while Loongson-1 is 32-bit SoC, we rename both file names > and Kconfig symbols from loongson/loongson1 to loongson64/loongson32. > > V2: Update Kconfig description. This ^^^^ needs to be below the '---' part of the patch because it should not be part of the commit message. It is just a changelog for the patch itself. > > Signed-off-by: Huacai Chen > --- ^^^ Please add "V2:..." here instead. -- markos From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailapp01.imgtec.com ([195.59.15.196]:18102 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27011376AbbDUJiTqdHWv (ORCPT ); Tue, 21 Apr 2015 11:38:19 +0200 Message-ID: <55361A86.9060000@imgtec.com> Date: Tue, 21 Apr 2015 10:38:14 +0100 From: Markos Chandras MIME-Version: 1.0 Subject: Re: [PATCH V2] MIPS: Loongson: Naming style cleanup and rework References: <1429581635-26476-1-git-send-email-chenhc@lemote.com> In-Reply-To: <1429581635-26476-1-git-send-email-chenhc@lemote.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Huacai Chen , Ralf Baechle Cc: "Steven J. Hill" , linux-mips@linux-mips.org, Fuxin Zhang , Zhangjin Wu , Kelvin Cheung Message-ID: <20150421093814.5kY4Czvlory9eTojLGf8YQHFY1h7u40pplwvZrU0GrA@z> Hi, On 04/21/2015 03:00 AM, Huacai Chen wrote: > Currently, code of Loongson-2/3 is under loongson directory and code of > Loongson-1 is under loongson1 directory. Besides, there are Kconfig > options such as MACH_LOONGSON and MACH_LOONGSON1. This naming style is > very ugly and confusing. Since Loongson-2/3 are both 64-bit general- > purpose CPU while Loongson-1 is 32-bit SoC, we rename both file names > and Kconfig symbols from loongson/loongson1 to loongson64/loongson32. > > V2: Update Kconfig description. This ^^^^ needs to be below the '---' part of the patch because it should not be part of the commit message. It is just a changelog for the patch itself. > > Signed-off-by: Huacai Chen > --- ^^^ Please add "V2:..." here instead. -- markos