All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	Intel-gfx@lists.freedesktop.org,
	Daniel Vetter <daniel.vetter@ffwll.ch>
Subject: Re: [RFC] drm/i915/skl: Use plane update function from mmio flips
Date: Tue, 21 Apr 2015 11:01:03 +0100	[thread overview]
Message-ID: <55361FDF.6020009@linux.intel.com> (raw)
In-Reply-To: <20150421095142.GJ17348@nuc-i3427.alporthouse.com>


Hi,

On 04/21/2015 10:51 AM, Chris Wilson wrote:
> On Tue, Apr 21, 2015 at 10:29:52AM +0100, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Avoids duplicating the code.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
>> Cc: Sonika Jindal <sonika.jindal@intel.com>
>> Cc: Damien Lespiau <damien.lespiau@intel.com>
>> ---
>> Can we do this?
>
> Sure, but I'd like to see update_primary_plane split into two in that
> case. One to precalcuate the parameters, then the second to apply them
> as we skip the first here (due to doing the setup in process context)
> and want the second to run inside the vblank evasion logic (and the
> unbounded nature of the current update_primary_plane logic scares me).

What part is unbounded? I don't see anything blocking?

As a side note, watermarks seem to be not handled at all in the flip 
path as well...

Regards,

Tvrtko

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-04-21 10:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-21  9:29 [RFC] drm/i915/skl: Use plane update function from mmio flips Tvrtko Ursulin
2015-04-21  9:51 ` Chris Wilson
2015-04-21 10:01   ` Tvrtko Ursulin [this message]
2015-04-21 10:07     ` Chris Wilson
2015-04-21 12:18       ` Tvrtko Ursulin
2015-04-23 19:15         ` Daniel Vetter
2015-04-23 20:17           ` Chris Wilson
2015-04-24  8:31           ` Tvrtko Ursulin
2015-05-04 13:20             ` Daniel Vetter
2015-05-06  9:31               ` Tvrtko Ursulin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55361FDF.6020009@linux.intel.com \
    --to=tvrtko.ursulin@linux.intel.com \
    --cc=Intel-gfx@lists.freedesktop.org \
    --cc=chris@chris-wilson.co.uk \
    --cc=daniel.vetter@ffwll.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.