From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jennifer Herbert Subject: Re: [PATCHv3 0/4] Use ticket locks for spinlocks Date: Tue, 21 Apr 2015 12:24:55 +0100 Message-ID: <55363387.6040900@citrix.com> References: <1429611088-23950-1-git-send-email-david.vrabel@citrix.com> <55364119020000780007434E@mail.emea.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YkWGx-00010f-2f for xen-devel@lists.xenproject.org; Tue, 21 Apr 2015 11:23:23 +0000 In-Reply-To: <55364119020000780007434E@mail.emea.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , David Vrabel Cc: Keir Fraser , Ian Campbell , Stefano Stabellini , Andrew Cooper , Tim Deegan , xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org On 21/04/15 11:22, Jan Beulich wrote: > Despite both pictures saying micro-seconds at the respective axis (and > hence the problem not being _as bad_) - did the data collection reveal > where these IRQ disable regions are, so we could look into eliminating > them? (ISTR there being some open coded IRQ-disable, lock, unlock, > IRQ-restore/enable sequences, but I'm not sure whether they got > eliminated already.) Jan The location of the locks was not collected, (Other then if it was from a spinlock or not) but I'm certainly considering doing this, as another graph of duration against cumulative time, shows the majority of time spent with interrupts disabled, is during code that keeps it disabled for long contiguous periods, all using raw (not spinlock) Interrupt disable. (A few occurrences, but very long when they happen) It would certainly be interesting to know where these come from. -jenny