Re: [PATCH 3/3] Input: adp5589-keys: fix event count mask

[Michael Hennerich <michael.hennerich@analog.com>]

On 04/21/2015 04:21 PM, Guido Martínez wrote:
> The event mask was specified as 0xF (4 bits) when in reality is 0x1F (5
> bits) in order to be capable of representing all FIFO length values from
> 0 to 16.
>
> This caused a problem: when the keypad reported 16 pending events the
> driver took it as 0, and did nothing. This in turn caused the keypad to
> re-issue the interrupt over and over again.
>
> Fixes: 9d2e173644bb ('Input: ADP5589 - new driver for I2C Keypad Decoder and I/O Expander')
> Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
> ---
>   drivers/input/keyboard/adp5589-keys.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/keyboard/adp5589-keys.c b/drivers/input/keyboard/adp5589-keys.c
> index 8709a7f..0419a7a 100644
> --- a/drivers/input/keyboard/adp5589-keys.c
> +++ b/drivers/input/keyboard/adp5589-keys.c
> @@ -180,7 +180,7 @@
>   #define LOGIC2_STAT	(1 << 7)	/* ADP5589 only */
>   #define LOGIC1_STAT	(1 << 6)
>   #define LOCK_STAT	(1 << 5)	/* ADP5589 only */
> -#define KEC		0xF
> +#define KEC		0x1F
>   
>   /* PIN_CONFIG_D Register */
>   #define C4_EXTEND_CFG	(1 << 6)	/* RESET2 */


-- 
Greetings,
Michael

--
Analog Devices GmbH      Wilhelm-Wagenfeld-Str. 6      80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin,
Margaret Seif

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html