All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Ceresoli <luca@lucaceresoli.net>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC 2/4] legal-info: allow to declare the actual sources for binary packages
Date: Tue, 21 Apr 2015 16:54:26 +0200	[thread overview]
Message-ID: <553664A2.6050705@lucaceresoli.net> (raw)
In-Reply-To: <54D373D7.3010402@lucaceresoli.net>

Hi,

for the records, I have not forgot this patchset...

Luca Ceresoli wrote:
> Dear Arnout,
>
> Arnout Vandecappelle wrote:
[...]
>>> +else
>>> +ifneq ($$($(2)_ACTUAL_SOURCE_TARBALL),$$($(2)_SOURCE))
>>> +    $(call
>>> DOWNLOAD,$$($(2)_ACTUAL_SOURCE_SITE:/=)/$$($(2)$($(PKG)_SITE:/=)_ACTUAL_SOURCE_TARBALL))
>>>
>>
>>   I think the $($(PKG)_SITE:/=) construct was just introduced because
>> for some
>> packages, the _SITE ends with a / and that should be stripped, and we
>> were too
>> lazy to fix the packages. Hm, looks like all the the external
>> toolchain _SITEs
>> end with a /...
>
> So I'll remove all of those '/'s from toolchain-external.mk first...

I started working on Arnout's comment above and sent a patchset to
cleanup _SITE URLs with a trailing '/'. I sent a patchset in March
(http://lists.busybox.net/pipermail/buildroot/2015-March/121502.html)
for that.

That patchset was partially applied, but an improvement was asked before
it could be fully applied.

So the present patchset sits on the bottom of my stack, until I have
time to implement the requested improvement...

I marked this patched as "Changes Requested" in patchwork, and will
send a v2 when possible, along with the other improvements requested
in this thread (which hopefully won't push again on my stack!).

-- 
Luca

  reply	other threads:[~2015-04-21 14:54 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-02 11:43 [Buildroot] [RFC 0/4] legal-info: save the external-toolchain source archive Luca Ceresoli
2015-01-02 11:43 ` [Buildroot] [RFC 1/4] legal-info: remove FOO_MANIFEST_TARBALL and FOO_MANIFEST_SITE defaults Luca Ceresoli
2015-02-02 21:28   ` Arnout Vandecappelle
2015-02-02 21:49   ` Peter Korsgaard
2015-01-02 11:43 ` [Buildroot] [RFC 2/4] legal-info: allow to declare the actual sources for binary packages Luca Ceresoli
2015-02-02 21:47   ` Arnout Vandecappelle
2015-02-02 21:49     ` Arnout Vandecappelle
2015-02-05 13:44     ` Luca Ceresoli
2015-04-21 14:54       ` Luca Ceresoli [this message]
2015-01-02 11:43 ` [Buildroot] [RFC 3/4] toolchain-externel: mass-define actual source tarball for known patterns Luca Ceresoli
2015-02-02 21:57   ` Arnout Vandecappelle
2015-01-02 11:43 ` [Buildroot] [RFC 4/4] toolchain-external: define actual sources for arago toolchains Luca Ceresoli
2015-02-02 21:58   ` Arnout Vandecappelle
2015-02-02 21:24 ` [Buildroot] [RFC 0/4] legal-info: save the external-toolchain source archive Arnout Vandecappelle
2015-02-05 13:25   ` Luca Ceresoli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=553664A2.6050705@lucaceresoli.net \
    --to=luca@lucaceresoli.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.