From: George Dunlap <george.dunlap@eu.citrix.com>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
xen-devel@lists.xensource.com
Cc: george.dunlap@citrix.com
Subject: Re: [PATCH 2/5] raisin: remove duplicate source config in raise
Date: Tue, 21 Apr 2015 16:09:37 +0100 [thread overview]
Message-ID: <55366831.9090406@eu.citrix.com> (raw)
In-Reply-To: <1429628103-10979-2-git-send-email-stefano.stabellini@eu.citrix.com>
On 04/21/2015 03:55 PM, Stefano Stabellini wrote:
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
I take it this got here by a bad merge or somethign?
Acked-by: George Dunlap <george.dunlap@eu.citrix.com>
> ---
> raise | 15 +++++----------
> 1 file changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/raise b/raise
> index bce6908..68dbfd8 100755
> --- a/raise
> +++ b/raise
> @@ -17,9 +17,12 @@ _help() {
> }
>
> # Include your defaults
> -if [[ -e "./config" ]] ; then
> - . ./config
> +if [[ ! -e "./config" ]]
> +then
> + echo "No config file found, copying default config"
> + cp defconfig config
> fi
> +source ./config
>
> # To use this as a library, set RAISIN_PATH appropriately
> [[ -z "$RAISIN_PATH" ]] && RAISIN_PATH="$PWD/lib"
> @@ -29,14 +32,6 @@ source ${RAISIN_PATH}/common-functions.sh
> source ${RAISIN_PATH}/git-checkout.sh
> source ${RAISIN_PATH}/commands.sh
>
> -# Include your defaults
> -if [[ ! -e "./config" ]] ; then
> - echo "No config file found, copying default config"
> - cp defconfig config
> -fi
> -
> -source ./config
> -
> # Set up basic functionality
> common_init
>
>
next prev parent reply other threads:[~2015-04-21 15:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-21 14:54 [PATCH 0/5] raisin: introduce ovmf and linux Stefano Stabellini
2015-04-21 14:54 ` [PATCH 1/5] raisin: introduce _verbose_echo Stefano Stabellini
2015-04-21 15:09 ` George Dunlap
2015-04-21 15:37 ` Stefano Stabellini
2015-04-21 14:55 ` [PATCH 2/5] raisin: remove duplicate source config in raise Stefano Stabellini
2015-04-21 15:09 ` George Dunlap [this message]
2015-04-21 15:42 ` Stefano Stabellini
2015-04-21 14:55 ` [PATCH 3/5] raisin: rename ARCH to RAISIN_ARCH Stefano Stabellini
2015-04-21 15:09 ` George Dunlap
2015-04-21 14:55 ` [PATCH 4/5] raisin: introduce ovmf Stefano Stabellini
2015-04-21 15:03 ` George Dunlap
2015-04-21 15:43 ` Stefano Stabellini
2015-04-21 15:45 ` George Dunlap
2015-04-21 15:46 ` George Dunlap
2015-04-21 14:55 ` [PATCH 5/5] raisin: build linux Stefano Stabellini
2015-04-21 15:11 ` George Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55366831.9090406@eu.citrix.com \
--to=george.dunlap@eu.citrix.com \
--cc=george.dunlap@citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.