From: Jan Kiszka <jan.kiszka@siemens.com>
To: Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>,
xenomai@xenomai.org
Cc: xenomai-git@xenomai.org
Subject: Re: [Xenomai] [Xenomai-git] Jan Kiszka : lib/cobalt: Rework minimum stack size enforcement
Date: Tue, 21 Apr 2015 18:04:42 +0200 [thread overview]
Message-ID: <5536751A.6080609@siemens.com> (raw)
In-Reply-To: <20150421152715.GV7109@hermes.click-hack.org>
On 2015-04-21 17:27, Gilles Chanteperdrix wrote:
> On Tue, Apr 21, 2015 at 05:22:34PM +0200, git repository hosting wrote:
>> +COBALT_IMPL(int, pthread_attr_setstack, (pthread_attr_t *attr, void *stackaddr,
>> + size_t stacksize))
>> +{
>> + if (stacksize < COBALT_STACKSIZE_MIN)
>> + return -EINVAL;
>> + return __STD(pthread_attr_setstack)(attr, stackaddr, stacksize);
>> +}
>
> As I said, there is no reason for Xenomai to enforce a task size
> larger than PTHREAD_STACK_MIN. This breaks POSIX compliance, and is
> useless.
Then we should not use printf & Co. from any trampoline function, e.g.
vxworks/taskLib.c:task_trampoline. I only tried with a local skin, but I
bet the issue is reproducible with that one.
For that reason, I went down the conservative path.
Jan
--
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2015-04-21 16:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1Yka0Q-00008c-Jh@sd-51317.xenomai.org>
2015-04-21 15:27 ` [Xenomai] [Xenomai-git] Jan Kiszka : lib/cobalt: Rework minimum stack size enforcement Gilles Chanteperdrix
2015-04-21 16:04 ` Jan Kiszka [this message]
2015-04-21 16:06 ` Gilles Chanteperdrix
2015-04-21 16:12 ` Jan Kiszka
2015-04-21 16:16 ` Gilles Chanteperdrix
2015-04-21 16:20 ` Jan Kiszka
2015-04-21 16:32 ` Gilles Chanteperdrix
2015-04-21 16:37 ` Jan Kiszka
2015-04-21 16:40 ` Gilles Chanteperdrix
2015-04-21 17:52 ` Jan Kiszka
2015-04-21 17:56 ` Gilles Chanteperdrix
2015-04-21 18:04 ` Jan Kiszka
2015-04-21 18:16 ` Gilles Chanteperdrix
2015-04-21 18:25 ` Gilles Chanteperdrix
2015-04-21 18:25 ` Jan Kiszka
2015-04-21 18:35 ` Gilles Chanteperdrix
2015-04-21 18:44 ` Gilles Chanteperdrix
2015-04-21 16:38 ` Gilles Chanteperdrix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5536751A.6080609@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=gilles.chanteperdrix@xenomai.org \
--cc=xenomai-git@xenomai.org \
--cc=xenomai@xenomai.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.