All of lore.kernel.org
 help / color / mirror / Atom feed
From: York Sun <yorksun@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] spl: descend into lib/ for all the SPL boards
Date: Tue, 21 Apr 2015 09:53:39 -0700	[thread overview]
Message-ID: <55368093.4030902@freescale.com> (raw)
In-Reply-To: <1429587446-437-1-git-send-email-yamada.masahiro@socionext.com>



On 04/20/2015 08:37 PM, Masahiro Yamada wrote:
> Currently, CONFIG_SPL_LIBGENERIC_SUPPORT must be defined
> to build under lib/ directory for SPL.
> 
> This directory contains very basic functions such as memcpy, memset
> in lib/string.c, so it should be very useful for all the boards.
> 
> Because SPL always enables compiler's garbage collection, this change
> should not give impact on its memory footprint.
> 
> Let's allow SPL to descend into lib/ all the time.  As a result,
> CONFIG_SPL_LIBGENERIC_SUPPORT is no longer necessary.

If this macro is not needed, do you want to remove it from README?

> 
> Four files must be adjusted to avoid multiple definition error.
> 
>  - arch/powerpc/cpu/mpc85xx/spl_minimal.c
>     udelay() is not a weak function.  __udelay() is overridable.
> 
>  - arch/powerpc/lib/time.c
>     MPC85xx has its own udelay for CONFIG_SPL_INIT_MINIAL.
>     Enclose the definition with ifdefs.
> 
>  - board/armadeus/apf27/apf27.c
>  - board/vpac270/onenand.c
>     Do not duplicate hang()
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---

Tested on multiple mpc85xx boards. Most are OK but I see issues with B4860QDS
and T4240QDS NAND boot. Probably not caused by this patch. I will ask board
maintainers to follow up.

York

  reply	other threads:[~2015-04-21 16:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-21  3:37 [U-Boot] [PATCH] spl: descend into lib/ for all the SPL boards Masahiro Yamada
2015-04-21 16:53 ` York Sun [this message]
2015-04-23 17:43   ` Simon Glass
2015-04-22 14:14 ` Tom Rini
2015-04-23 17:37   ` Simon Glass
2015-04-24 18:34     ` Scott Wood
2015-04-24 20:01       ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55368093.4030902@freescale.com \
    --to=yorksun@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.