All of lore.kernel.org
 help / color / mirror / Atom feed
From: Emil Velikov <emil.l.velikov@gmail.com>
To: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>,
	dri-devel@lists.freedesktop.org
Cc: emil.l.velikov@gmail.com
Subject: Re: [PATCH v2] modetest: initialize handles/pitches in set_plane()
Date: Tue, 21 Apr 2015 20:10:04 +0000	[thread overview]
Message-ID: <5536AE9C.2000707@gmail.com> (raw)
In-Reply-To: <1429559445-3494-1-git-send-email-tjakobi@math.uni-bielefeld.de>

Hi Tobias,

On 20/04/15 19:50, Tobias Jakobi wrote:
> Only the 'offsets' array was initialized to zero.
> Since bo_create only sets the handles which are
> necessary, were we passing garbage data to the
> kernel when calling drmModeAddFB2 later.
> 
> The issue only seems to appear when passing e.g.
> NV12 data to the kernel, a case where not only
> handles[0] is used. I therefore also removed the
> corresponding comment.
> 
> v2: Do the same for set_mode(), set_cursors()
>     and test_page_flip().
> 
Nice catch. I will push this in a day or so, unless someone objects.

This and the other patches from Joonyoung Shim make me question how many
people have seriously used this tool.

Thanks
Emil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2015-04-21 19:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-20 19:50 [PATCH v2] modetest: initialize handles/pitches in set_plane() Tobias Jakobi
2015-04-21 20:10 ` Emil Velikov [this message]
2015-04-21 19:15   ` Ilia Mirkin
2015-04-23 13:39     ` Tobias Jakobi
2015-04-23 14:32       ` Ilia Mirkin
2015-04-23 14:47         ` Tobias Jakobi
2015-04-23 16:36     ` Emil Velikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5536AE9C.2000707@gmail.com \
    --to=emil.l.velikov@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=tjakobi@math.uni-bielefeld.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.