From: Paolo Bonzini <pbonzini@redhat.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: tweak types of fields in kvm_lapic_irq
Date: Wed, 22 Apr 2015 12:27:55 +0200 [thread overview]
Message-ID: <553777AB.7080909@redhat.com> (raw)
In-Reply-To: <20150422093542.GA30285@potion.brq.redhat.com>
On 22/04/2015 11:35, Radim Krčmář wrote:
> > Change the level field to bool, since we assign 1 sometimes, but
> > just mask icr_low with APIC_INT_ASSERT in apic_send_-ipi.
>
> Would be more consistent to change that assignment instead ...
> If we dropped the idea that struct kvm_lapic_irq fields can be bitORed
> to get the ICR, we could also easily change trig_mode/dest_mode to bool
> level_trig/logical_dest. (I can do a followup patch.)
Right, I thought of both. However, level is something that has an
obviously understandable meaning as a bool, while trig_mode/dest_mode as
you said have to be renamed as well.
You're right on the u8 type for vector, too. But I probably will end up
not committing this patch at all...
Paolo
prev parent reply other threads:[~2015-04-22 10:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-21 17:01 [PATCH] KVM: x86: tweak types of fields in kvm_lapic_irq Paolo Bonzini
2015-04-22 9:35 ` Radim Krčmář
2015-04-22 10:27 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553777AB.7080909@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.