From: "liujian (CE)" <liujian56@huawei.com>
To: "Iwashima, Kuniyuki" <kuniyu@amazon.co.jp>
Cc: Paolo Abeni <pabeni@redhat.com>,
Greg KH <gregkh@linuxfoundation.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
Network Development <netdev@vger.kernel.org>,
Jakub Kicinski <kuba@kernel.org>
Subject: RE: [Qestion] abort backport commit ("net/ulp: prevent ULP without clone op from entering the LISTEN status") in stable-4.19.x
Date: Sat, 4 Mar 2023 02:45:44 +0000 [thread overview]
Message-ID: <55378c79847a4fe092cc924e4df24f4d@huawei.com> (raw)
In-Reply-To: <D899D5DA-C73C-46C4-A123-A10F0D389D0D@amazon.co.jp>
> -----Original Message-----
> From: Iwashima, Kuniyuki [mailto:kuniyu@amazon.co.jp]
> Sent: Saturday, March 4, 2023 9:13 AM
> To: liujian (CE) <liujian56@huawei.com>
> Cc: Paolo Abeni <pabeni@redhat.com>; Greg KH
> <gregkh@linuxfoundation.org>; stable@vger.kernel.org; Network
> Development <netdev@vger.kernel.org>; Iwashima, Kuniyuki
> <kuniyu@amazon.co.jp>; Jakub Kicinski <kuba@kernel.org>
> Subject: Re: [Qestion] abort backport commit ("net/ulp: prevent ULP without
> clone op from entering the LISTEN status") in stable-4.19.x
>
> From: Jakub Kicinski <kuba@kernel.org>
> Date: Fri, 3 Mar 2023 17:06:08 -0800
> > On Fri, 3 Mar 2023 10:52:15 +0000 liujian (CE) wrote:
> > > When I was working on CVE-2023-0461, I found the below backport
> commit in stable-4.19.x maybe something wrong?
> > >
> > > 755193f2523c ("net/ulp: prevent ULP without clone op from entering
> > > the LISTEN status")
> > >
> > > 1. err = -EADDRINUSE in inet_csk_listen_start() was removed. But it
> > > is the error code when get_port() fails.
> >
> > I think you're right, we should add setting the err back.
>
> Yes, the same issue happened on 5.15.88, but I forgot to check other stable
> branches.
> I'll check them and post fixes later.
> https://lore.kernel.org/stable/20230220133555.140865685@linuxfoundation.
> org/
>
Thanks Iwashima.
>
> >
> > > 2. The change in __tcp_set_ulp() should not be discarded?
> >
> > That part should be fine, all ULPs in 4.19 (i.e. TLS) should fail the
> > ->init() call if sk_state != ESTABLISHED.
Got it. Thanks Jakub.
next prev parent reply other threads:[~2023-03-04 2:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-04 1:12 [Qestion] abort backport commit ("net/ulp: prevent ULP without clone op from entering the LISTEN status") in stable-4.19.x Iwashima, Kuniyuki
2023-03-04 2:45 ` liujian (CE) [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-03-03 10:52 liujian (CE)
2023-03-04 1:06 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55378c79847a4fe092cc924e4df24f4d@huawei.com \
--to=liujian56@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.co.jp \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.