From: Ivan Vecera <ivecera@redhat.com>
To: Joe Perches <joe@perches.com>
Cc: netdev@vger.kernel.org, Sathya Perla <sathya.perla@emulex.com>,
Subbu Seetharaman <subbu.seetharaman@emulex.com>,
Ajit Khaparde <ajit.khaparde@emulex.com>
Subject: Re: [PATCH net-next v2] be2net: log link status
Date: Wed, 22 Apr 2015 16:17:23 +0200 [thread overview]
Message-ID: <5537AD73.5070401@redhat.com> (raw)
In-Reply-To: <1429711674.32612.8.camel@perches.com>
On 04/22/2015 04:07 PM, Joe Perches wrote:
> On Wed, 2015-04-22 at 15:43 +0200, Ivan Vecera wrote:
>> >The driver unlike other drivers does not log link state changes.
> Why add all the speed stuff, why not add a query instead?
>
> I think it'd be simpler to add a line like:
> status = be_cmd_link_status_query(adapter, &speed, &status, 0);
> before emitting speed/link_status
The func be_link_status_update() is also called from
be_async_link_state_process() and I'm not sure if it is possible to call
be_cmd_link_status_query() from its context.
Ivan
next prev parent reply other threads:[~2015-04-22 14:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-22 13:43 [PATCH net-next v2] be2net: log link status Ivan Vecera
2015-04-22 14:07 ` Joe Perches
2015-04-22 14:17 ` Ivan Vecera [this message]
2015-04-22 22:44 ` David Miller
2015-04-23 6:35 ` Sathya Perla
2015-04-23 6:31 ` Sathya Perla
2015-04-23 6:52 ` Ivan Vecera
2015-04-28 14:32 ` Ivan Vecera
2015-04-28 16:44 ` David Miller
2015-04-28 19:32 ` Ivan Vecera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5537AD73.5070401@redhat.com \
--to=ivecera@redhat.com \
--cc=ajit.khaparde@emulex.com \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
--cc=sathya.perla@emulex.com \
--cc=subbu.seetharaman@emulex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.