From: Eric Blake <eblake@redhat.com>
To: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Cc: kchamart@redhat.com, lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH 4/5] scripts: qmp-shell: add transaction subshell
Date: Wed, 22 Apr 2015 09:28:01 -0600 [thread overview]
Message-ID: <5537BE01.2090604@redhat.com> (raw)
In-Reply-To: <5537B816.4040907@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 786 bytes --]
On 04/22/2015 09:02 AM, John Snow wrote:
> Yeah, not a big deal. The function that invokes this one actually
> explicitly checks for an empty string and avoids __build_cmd already.
>
> If it gets spaces, It actually currently errors out with "list index out
> of range" which is not helpful or interesting.
>
> This will at least improve it to do "nothing."
>
> The behavior of just ignoring empty and blank lines is suitable
> regardless of mode, I think, unless you have a counter argument.
No counter argument here; but it does mean that we should improve the
commit message, to mention that it is an intentionally nice side effect
of the change :)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-04-22 15:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-22 2:02 [Qemu-devel] [PATCH 0/5] scripts: qmp-shell: add transaction support John Snow
2015-04-22 2:02 ` [Qemu-devel] [PATCH 1/5] scripts: qmp-shell: refactor helpers John Snow
2015-04-22 14:25 ` Eric Blake
2015-04-22 2:02 ` [Qemu-devel] [PATCH 2/5] scripts: qmp-shell: add support for [] expressions John Snow
2015-04-22 14:28 ` Eric Blake
2015-04-22 14:31 ` John Snow
2015-04-22 2:02 ` [Qemu-devel] [PATCH 3/5] scripts: qmp-shell: allow single-quotes in JSON expressions John Snow
2015-04-22 14:34 ` Eric Blake
2015-04-22 14:39 ` John Snow
2015-04-22 15:04 ` John Snow
2015-04-22 15:18 ` Eric Blake
2015-04-22 2:02 ` [Qemu-devel] [PATCH 4/5] scripts: qmp-shell: add transaction subshell John Snow
2015-04-22 14:48 ` Eric Blake
2015-04-22 15:02 ` John Snow
2015-04-22 15:28 ` Eric Blake [this message]
2015-04-22 2:02 ` [Qemu-devel] [PATCH 5/5] scripts: qmp-shell: Add verbose flag John Snow
2015-04-22 14:50 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5537BE01.2090604@redhat.com \
--to=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=kchamart@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.