From: Eric Blake <eblake@redhat.com>
To: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Cc: kchamart@redhat.com, lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 2/4] scripts: qmp-shell: Expand support for QMP expressions
Date: Wed, 22 Apr 2015 11:25:02 -0600 [thread overview]
Message-ID: <5537D96E.40308@redhat.com> (raw)
In-Reply-To: <5537D7F1.1090700@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 847 bytes --]
On 04/22/2015 11:18 AM, Eric Blake wrote:
> On 04/22/2015 10:21 AM, John Snow wrote:
>> This includes support for [] expressions, single-quotes in
>> QMP expressions (which is not strictly a part of JSON), and
>> the ability to use "True" or "False" literals instead of
>> JSON's lowercased 'true' and 'false' literals.
>>
>>
>> Signed-off-by: John Snow <jsnow@redhat.com>
>> ---
>> scripts/qmp/qmp-shell | 44 ++++++++++++++++++++++++++++----------------
>> 1 file changed, 28 insertions(+), 16 deletions(-)
>
> As far as I can tell, this makes qmp-shell strictly more useful, so I
> have no qualms giving:
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
When combined with your one-line touchup, of course.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-04-22 17:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-22 16:21 [Qemu-devel] [PATCH v2 0/4] scripts: qmp-shell: add transaction support John Snow
2015-04-22 16:21 ` [Qemu-devel] [PATCH v2 1/4] scripts: qmp-shell: refactor helpers John Snow
2015-04-22 16:21 ` [Qemu-devel] [PATCH v2 2/4] scripts: qmp-shell: Expand support for QMP expressions John Snow
2015-04-22 16:41 ` John Snow
2015-04-22 17:18 ` Eric Blake
2015-04-22 17:25 ` Eric Blake [this message]
2015-04-22 17:33 ` John Snow
2015-04-22 16:21 ` [Qemu-devel] [PATCH v2 3/4] scripts: qmp-shell: add transaction subshell John Snow
2015-04-22 16:21 ` [Qemu-devel] [PATCH v2 4/4] scripts: qmp-shell: Add verbose flag John Snow
2015-04-22 19:27 ` [Qemu-devel] [PATCH v2 0/4] scripts: qmp-shell: add transaction support John Snow
2015-04-23 13:11 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5537D96E.40308@redhat.com \
--to=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=kchamart@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.