From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47247) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YkyPt-0001Lz-9e for qemu-devel@nongnu.org; Wed, 22 Apr 2015 13:26:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YkyPs-0005Z7-GT for qemu-devel@nongnu.org; Wed, 22 Apr 2015 13:26:29 -0400 Message-ID: <5537D9B1.5050403@redhat.com> Date: Wed, 22 Apr 2015 19:26:09 +0200 From: Max Reitz MIME-Version: 1.0 References: <65b2cc1b55bd7869244ce9bebcf671ddc15ac7d6.1429196435.git.berto@igalia.com> In-Reply-To: <65b2cc1b55bd7869244ce9bebcf671ddc15ac7d6.1429196435.git.berto@igalia.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/8] block: Add QMP support for streaming to an intermediate layer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia , qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org, Stefan Hajnoczi On 16.04.2015 17:12, Alberto Garcia wrote: > This patch makes the 'device' paramater of the 'block-stream' command > accept a node name as well as a device name. > > In addition to that, operation blockers will be checked in all > intermediate nodes between the top and the base node. > > Since qmp_block_stream() now uses the error from bdrv_lookup_bs() and > no longer returns DeviceNotFound, iotest 030 is updated to expect > GenericError instead. > > Signed-off-by: Alberto Garcia > --- > blockdev.c | 20 ++++++++++---------- > qapi/block-core.json | 10 +++++++--- > tests/qemu-iotests/030 | 2 +- > 3 files changed, 18 insertions(+), 14 deletions(-) Reviewed-by: Max Reitz