From: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
To: Johan Hovold <johan@kernel.org>,
Dirk Behme <dirk.behme@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-gpio@vger.kernel.org,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <acourbot@nvidia.com>
Subject: Re: [PATCH] Documentation: gpiolib: sysfs: high can be any nonzero value
Date: Thu, 23 Apr 2015 00:12:46 +0300 [thread overview]
Message-ID: <55380ECE.4040805@mentor.com> (raw)
In-Reply-To: <20150422171024.GF16828@localhost>
Hi Greg,
On 22.04.2015 20:10, Johan Hovold wrote:
> On Wed, Apr 22, 2015 at 06:39:46PM +0200, Dirk Behme wrote:
>> With the commit 79a9becda8940d ("gpiolib: export descriptor-based
>> GPIO interface") the gpiolib can return any nonzero value for high.
>> Not only 1. Correct this in the documentation.
>
> As _gpiod_get_raw_value returns a bool, I fail to see how that could
> happen.
>
> Ah, that was fixed by commit 23600969ff13 ("gpio: clamp returned values
> to the boolean range") in 3.15.
>
> Looks like that one should be backported to 3.14 instead.
>
I tested that 23600969ff13 clearly applies to 3.14.y and I confirm that
it fixes the problem.
Would it be possible for you to backport this commit to LTS 3.14.y,
since it fixes quite critical sysfs API regression? Or should I send the
patch to stable@vger.kernel.org ?
Thank you in advance!
--
With best wishes,
Vladimir
next prev parent reply other threads:[~2015-04-22 21:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-22 16:39 [PATCH] Documentation: gpiolib: sysfs: high can be any nonzero value Dirk Behme
2015-04-22 17:10 ` Johan Hovold
2015-04-22 21:12 ` Vladimir Zapolskiy [this message]
2015-05-02 16:36 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55380ECE.4040805@mentor.com \
--to=vladimir_zapolskiy@mentor.com \
--cc=acourbot@nvidia.com \
--cc=dirk.behme@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.