From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexei Starovoitov Subject: Re: [RFC 2/3] tc: deprecate TC_ACT_QUEUED Date: Wed, 22 Apr 2015 15:22:12 -0700 Message-ID: <55381F14.4070708@plumgrid.com> References: <1429644476-8914-1-git-send-email-ast@plumgrid.com> <1429644476-8914-3-git-send-email-ast@plumgrid.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , Eric Dumazet , Jamal Hadi Salim , John Fastabend , netdev To: Cong Wang Return-path: Received: from mail-pd0-f173.google.com ([209.85.192.173]:33026 "EHLO mail-pd0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933307AbbDVWWQ (ORCPT ); Wed, 22 Apr 2015 18:22:16 -0400 Received: by pdbnk13 with SMTP id nk13so481760pdb.0 for ; Wed, 22 Apr 2015 15:22:16 -0700 (PDT) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On 4/21/15 10:02 PM, Cong Wang wrote: > On Tue, Apr 21, 2015 at 12:27 PM, Alexei Starovoitov wrote: >> TC_ACT_QUEUED was always an alias of TC_ACT_STOLEN. >> Get rid of redundant checks in all qdiscs. >> Instead do it once. > > The current code can be easily extended, while your code not. > I don't see the need of this change. well, iproute2 doesn't use TC_ACT_QUEUED action at all and TC_ACT_STOLEN is used by mirred. All in-tree qdiscs alias them. If you're saying that some future actions together with some future qdiscs may take advantage of that, then why they didn't use it over the last 10 years? Having both that do the same thing is only confusing. I think having one value to indicate 'stolen' condition makes TC code easier to understand. Jamal, what's your take on this?