From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] tools/libxc: Set HVM_PARAM_CONSOLE_EVTCHN during restore Date: Thu, 23 Apr 2015 10:24:04 +0100 Message-ID: <5538BA34.4090105@citrix.com> References: <1429757358-8271-1-git-send-email-boris.ostrovsky@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1429757358-8271-1-git-send-email-boris.ostrovsky@oracle.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Boris Ostrovsky , rshriram@cs.ubc.ca, yanghy@cn.fujitsu.com, ian.jackson@eu.citrix.com, stefano.stabellini@eu.citrix.com, ian.campbell@citrix.com, wei.liu2@citrix.com Cc: xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org On 23/04/15 03:49, Boris Ostrovsky wrote: > When resuming, the guest needs to check whether the port has changed. HVM > guests use this parameter to get the port number. > > (We can't always use xenstore where this value is also written: for example > on Linux the console is resumed very early, before the store is up). > > Signed-off-by: Boris Ostrovsky Reviewed-by: Andrew Cooper This bug is also present in migration v2 but mitigated in our case because of the binary we use to call xc_domain_restore() which also sets the evtchn up. I believe libxl is also fine for the same reason, but I will fix it nevertheless. ~Andrew > --- > tools/libxc/xc_domain_restore.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/tools/libxc/xc_domain_restore.c b/tools/libxc/xc_domain_restore.c > index 2ab9f46..f9dfd2d 100644 > --- a/tools/libxc/xc_domain_restore.c > +++ b/tools/libxc/xc_domain_restore.c > @@ -2328,7 +2328,10 @@ int xc_domain_restore(xc_interface *xch, int io_fd, uint32_t dom, > HVM_PARAM_PAE_ENABLED, pae)) > || (frc = xc_hvm_param_set(xch, dom, > HVM_PARAM_STORE_EVTCHN, > - store_evtchn)) ) > + store_evtchn)) > + || (frc = xc_hvm_param_set(xch, dom, > + HVM_PARAM_CONSOLE_EVTCHN, > + console_evtchn)) ) > { > PERROR("error setting HVM params: %i", frc); > goto out;