From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tetsuya Mukawa Subject: Re: [PATCH v3 0/5] Clean up pci uio implementations Date: Thu, 23 Apr 2015 18:48:56 +0900 Message-ID: <5538C008.4000308@igel.co.jp> References: <1426584645-28828-7-git-send-email-mukawa@igel.co.jp> <1427445553-3151-1-git-send-email-mukawa@igel.co.jp> <8CEF83825BEC744B83065625E567D7C204A0FF82@IRSMSX108.ger.corp.intel.com> <553873C5.1000909@igel.co.jp> <8CEF83825BEC744B83065625E567D7C204A19A4B@IRSMSX108.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit To: "Iremonger, Bernard" , "dev-VfR2kkLFssw@public.gmane.org" Return-path: In-Reply-To: <8CEF83825BEC744B83065625E567D7C204A19A4B-kPTMFJFq+rEMvF1YICWikbfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" On 2015/04/23 17:12, Iremonger, Bernard wrote: > >> -----Original Message----- >> From: Tetsuya Mukawa [mailto:mukawa-AlSX/UN32fvPDbFq/vQRIQ@public.gmane.org] >> Sent: Thursday, April 23, 2015 5:24 AM >> To: Iremonger, Bernard; dev-VfR2kkLFssw@public.gmane.org >> Cc: Richardson, Bruce; david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org >> Subject: Re: [PATCH v3 0/5] Clean up pci uio implementations >> >> On 2015/04/21 22:15, Iremonger, Bernard wrote: >>>> -----Original Message----- >>>> From: Tetsuya Mukawa [mailto:mukawa-AlSX/UN32fvPDbFq/vQRIQ@public.gmane.org] >>>> Sent: Friday, March 27, 2015 8:39 AM >>>> To: dev-VfR2kkLFssw@public.gmane.org >>>> Cc: Iremonger, Bernard; Richardson, Bruce; david.marchand-pdR9zngts4EAvxtiuMwx3w@public.gmane.org; >>>> Tetsuya Mukawa >>>> Subject: [PATCH v3 0/5] Clean up pci uio implementations >>>> >>>> This patch set cleans up pci uio implementation. These clean up are >>>> for consolidating pci uio implementation of linuxapp and bsdapp, and moving consolidated >> functions in eal common. >>>> Because of above, this patch set tries to implement linuxapp and bsdapp almost same. >>>> Actual consolidations will be done later patch set. >>>> >>>> PATCH v3 changes: >>>> - Squash patches related with pci_map_resource(). >>>> - Free maps[].path to easy to understand. >>>> (Thanks to Iremonger, Bernard) >>>> - Close fds opened in this function. >>>> - Remove unused path variable from mapped_pci_resource structure. >>>> >>>> PATCH v2 changes: >>>> - Move 'if-condition' to later patch series. >>>> - Fix memory leaks of path. >>>> - Fix typos. >>>> (Thanks to David Marchand) >>>> - Fix commit title and body. >>>> - Fix pci_map_resource() to handle MAP_FAILED. >>>> (Thanks to Iremonger, Bernard) >>>> >>>> Changes: >>>> - This patch set is derived from below. >>>> "[PATCH v2] eal: Port Hotplug support for BSD" >>>> - Set cfg_fd as -1, when cfg_fd is closed. >>>> (Thanks to Iremonger, Bernard) >>>> - Remove needless coding style fixings. >>>> - Fix coding style of if-else condition. >>>> (Thanks to Richardson, Bruce) >>>> >>>> >>>> >>>> Tetsuya Mukawa (5): >>>> eal: Fix coding style of eal_pci.c and eal_pci_uio.c >>>> eal: Close file descriptor of uio configuration >>>> eal: Fix memory leaks and needless increment of pci_map_addr >>>> eal/bsdapp: Change names of pci related data structure >>>> eal: Fix uio mapping differences between linuxapp and bsdapp >>>> >>>> lib/librte_eal/bsdapp/eal/eal_pci.c | 166 +++++++++++++++++------------ >>>> lib/librte_eal/linuxapp/eal/eal_pci_init.h | 1 - >>>> lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 91 +++++++++------- >>>> 3 files changed, 154 insertions(+), 104 deletions(-) >>>> >>>> -- >>>> 1.9.1 >>> Series >>> Acked-by: Bernard Iremonger >> Hi Bernard, >> >> Thanks for your checking. >> It seems I need to rebase this patches for latest matser branch. >> So I will update and submit it soon. >> >> Regards, >> Tetsuya > Hi Tetsuya, > I applied the v3 patches to the latest master branch on Monday last and there were no issues. > The patches built cleanly on Linux and Free BSD. > > Regards, > > Bernard. > Hi Bernard, Thanks. I made sure I could apply my patches to latest. I will prepare bottom half of port hotplug patches for BSD. Regards, Tetsuya