From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Date: Thu, 23 Apr 2015 10:40:38 +0000 Subject: Re: [PATCH] ARM: KVM: Remove pointless void pointer cast Message-Id: <5538CC26.3060601@redhat.com> List-Id: References: <1429783660-7222-1-git-send-email-firogm@gmail.com> In-Reply-To: <1429783660-7222-1-git-send-email-firogm@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Firo Yang , gleb@kernel.org Cc: kernel-janitors@vger.kernel.org, christoffer.dall@linaro.org, marc.zyngier@arm.com, linux@arm.linux.org.uk, kvm@vger.kernel.org On 23/04/2015 12:07, Firo Yang wrote: > No need to cast the void pointer returned by kmalloc() in > arch/arm/kvm/mmu.c::kvm_alloc_stage2_pgd(). > > Signed-off-by: Firo Yang > --- > arch/arm/kvm/mmu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/kvm/mmu.c b/arch/arm/kvm/mmu.c > index 1d5accb..ce0bce4 100644 > --- a/arch/arm/kvm/mmu.c > +++ b/arch/arm/kvm/mmu.c > @@ -691,8 +691,8 @@ int kvm_alloc_stage2_pgd(struct kvm *kvm) > * work. This is not used by the hardware and we have no > * alignment requirement for this allocation. > */ > - pgd = (pgd_t *)kmalloc(PTRS_PER_S2_PGD * sizeof(pgd_t), > - GFP_KERNEL | __GFP_ZERO); > + pgd = kmalloc(PTRS_PER_S2_PGD * sizeof(pgd_t), > + GFP_KERNEL | __GFP_ZERO); > > if (!pgd) { > kvm_free_hwpgd(hwpgd); > Acked-by: Paolo Bonzini From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH] ARM: KVM: Remove pointless void pointer cast Date: Thu, 23 Apr 2015 12:40:38 +0200 Message-ID: <5538CC26.3060601@redhat.com> References: <1429783660-7222-1-git-send-email-firogm@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: kernel-janitors@vger.kernel.org, christoffer.dall@linaro.org, marc.zyngier@arm.com, linux@arm.linux.org.uk, kvm@vger.kernel.org To: Firo Yang , gleb@kernel.org Return-path: In-Reply-To: <1429783660-7222-1-git-send-email-firogm@gmail.com> Sender: kernel-janitors-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 23/04/2015 12:07, Firo Yang wrote: > No need to cast the void pointer returned by kmalloc() in > arch/arm/kvm/mmu.c::kvm_alloc_stage2_pgd(). > > Signed-off-by: Firo Yang > --- > arch/arm/kvm/mmu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/kvm/mmu.c b/arch/arm/kvm/mmu.c > index 1d5accb..ce0bce4 100644 > --- a/arch/arm/kvm/mmu.c > +++ b/arch/arm/kvm/mmu.c > @@ -691,8 +691,8 @@ int kvm_alloc_stage2_pgd(struct kvm *kvm) > * work. This is not used by the hardware and we have no > * alignment requirement for this allocation. > */ > - pgd = (pgd_t *)kmalloc(PTRS_PER_S2_PGD * sizeof(pgd_t), > - GFP_KERNEL | __GFP_ZERO); > + pgd = kmalloc(PTRS_PER_S2_PGD * sizeof(pgd_t), > + GFP_KERNEL | __GFP_ZERO); > > if (!pgd) { > kvm_free_hwpgd(hwpgd); > Acked-by: Paolo Bonzini