From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57645)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1YlEs3-0002d8-FQ
	for qemu-devel@nongnu.org; Thu, 23 Apr 2015 07:00:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1YlErv-0005qd-HE
	for qemu-devel@nongnu.org; Thu, 23 Apr 2015 07:00:39 -0400
Received: from mailapp01.imgtec.com ([195.59.15.196]:44855)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Leon.Alrae@imgtec.com>) id 1YlErv-0005nz-9T
	for qemu-devel@nongnu.org; Thu, 23 Apr 2015 07:00:31 -0400
Message-ID: <5538D0C2.9080303@imgtec.com>
Date: Thu, 23 Apr 2015 12:00:18 +0100
From: Leon Alrae <leon.alrae@imgtec.com>
MIME-Version: 1.0
References: <CAKU=YwX94CozCUsADgYPB6Jy=NAeiC23w=vDB-64kPPxdiJ2Ug@mail.gmail.com>
	<CAFEAcA88ZgVA+RNjtWRDWbv5XV0Wbk41t102ORyGJR+1-Q9rqA@mail.gmail.com>
In-Reply-To: <CAFEAcA88ZgVA+RNjtWRDWbv5XV0Wbk41t102ORyGJR+1-Q9rqA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/3] arm: semihosting: Wire up A64 HLT
	0xf000
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christopher Covington <christopher.covington@linaro.org>
Cc: Peter Maydell <peter.maydell@linaro.org>, QEMU Developers <qemu-devel@nongnu.org>, Liviu Ionescu <ilg@livius.net>

Hi Christopher,

On 09/04/2015 18:57, Peter Maydell wrote:
> On 9 April 2015 at 18:23, Christopher Covington
> <christopher.covington@linaro.org> wrote:
>> On Fri, Mar 27, 2015 at 12:40 PM, Peter Maydell
>> <peter.maydell@linaro.org> wrote:
>>> You need to have the semihosting_enabled check here rather
>>> than in the do_interrupt code, because otherwise we won't
>>> behave correctly in the disabled case.
>>
>> Do you have suggestions for getting semihosting_enabled defined in
>> translate-a64.c? I'm likely doing something dumb, but while #include
>> "sysemu/sysemu.h" at first seemed like the obvious approach, and
>> appears to work for -softmmu, I'm getting errors with that when
>> building -linux-user.
> 
> sysemu.h is an ugly grab-bag of things that are specific to the
> system emulator config. Semihosting is always enabled for linux-user,
> so it doesn't have an equivalent switch.
> 
> Let's clean this up a bit, by creating a new include/exec/semihost.h,

Do you happen to have this clean up available somewhere? I just want to
make sure I'm not duplicating the work as my patches will touch the same
area.

Thanks,
Leon