From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46133) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlFjk-0000XY-6A for qemu-devel@nongnu.org; Thu, 23 Apr 2015 07:56:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YlFjg-0000vr-Ut for qemu-devel@nongnu.org; Thu, 23 Apr 2015 07:56:08 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:32956) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YlFjg-0000vg-PJ for qemu-devel@nongnu.org; Thu, 23 Apr 2015 07:56:04 -0400 Message-ID: <5538DDBE.5080403@imgtec.com> Date: Thu, 23 Apr 2015 12:55:42 +0100 From: Leon Alrae MIME-Version: 1.0 References: <1427894283-31953-1-git-send-email-leon.alrae@imgtec.com> <9DE872C8-4AE3-48FC-B4A1-61ADE4DB7F32@livius.net> <551CF623.7040506@imgtec.com> <551D086D.9010604@imgtec.com> <551D1BC2.10408@imgtec.com> <1C30C43D-CD89-4EBF-991A-9CC53019ED7B@livius.net> <6D39441BF12EF246A7ABCE6654B023532101BA54@LEMAIL01.le.imgtec.org> <1741D364-48FC-4682-B660-82A5B48F8DE4@livius.net> <55255556.8020504@imgtec.com> <2A76D025-D3C9-4023-B48B-F6870998C99A@livius.net> <553651ED.9080209@imgtec.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liviu Ionescu Cc: Peter Maydell , "christopher.covington@linaro.org" , Matthew Fortune , "qemu-devel@nongnu.org" On 21/04/2015 19:08, Liviu Ionescu wrote: > >> On 21 Apr 2015, at 16:34, Leon Alrae wrote: >> >> I'll resend the patch with dropped "RFC" as I would really like to go >> forward and finally close this issue. > > perhaps you should first take a closer look at the patch I submitted, since it covers not only parsing the arguments, but also grouping all semihosting related variables in a structure and using them where needed. Thanks for that patch. The issue I can see is that these changes could have been broken into 3 separate patches: (1) add -semihosting-cmdline option (2) convert to semihosting struct (3) improve the ARM semihosting. I think during the discussion eventually we resigned from adding top level -semihosting-cmdline option (1), but the other two parts (2) and (3) probably are still valuable. Please let me know if you want to extract (2) change and send it as a separate patch (note that there were some suggestions regarding the clean up on the other thread so probably syncing would be a good idea). If not that's fine, since this is relatively small amount of changes I can do that all in one shot while adding "arg=" suboption. Thanks, Leon